2013-10-13 06:16:12

by Michael Opdenacker

Subject: [PATCH] misc: phantom: remove deprecated IRQF_DISABLED

This patch proposes to remove the use of the IRQF_DISABLED flag

It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker <[email protected]>
---
drivers/misc/phantom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
index 68b7c77..3075492 100644
--- a/drivers/misc/phantom.c
+++ b/drivers/misc/phantom.c
@@ -395,7 +395,7 @@ static int phantom_probe(struct pci_dev *pdev,
iowrite32(0, pht->caddr + PHN_IRQCTL);
ioread32(pht->caddr + PHN_IRQCTL); /* PCI posting */
retval = request_irq(pdev->irq, phantom_isr,
- IRQF_SHARED | IRQF_DISABLED, "phantom", pht);
+ IRQF_SHARED, "phantom", pht);
if (retval) {
dev_err(&pdev->dev, "can't establish ISR\n");
goto err_unmo;
--
1.8.1.2

2013-10-14 08:49:46

by Jiri Slaby

Subject: Re: [PATCH] misc: phantom: remove deprecated IRQF_DISABLED

On 10/13/2013 08:16 AM, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <[email protected]>

Acked-by: Jiri Slaby <[email protected]>

Thanks.

> ---
> drivers/misc/phantom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
> index 68b7c77..3075492 100644
> --- a/drivers/misc/phantom.c
> +++ b/drivers/misc/phantom.c
> @@ -395,7 +395,7 @@ static int phantom_probe(struct pci_dev *pdev,
> iowrite32(0, pht->caddr + PHN_IRQCTL);
> ioread32(pht->caddr + PHN_IRQCTL); /* PCI posting */
> retval = request_irq(pdev->irq, phantom_isr,
> - IRQF_SHARED | IRQF_DISABLED, "phantom", pht);
> + IRQF_SHARED, "phantom", pht);
> if (retval) {
> dev_err(&pdev->dev, "can't establish ISR\n");
> goto err_unmo;
>


--
js
suse labs