2013-10-15 23:22:13

by Felipe Pena

Subject: [PATCH 1/1] drivers: hv: Fix wrong check for synic_event_page

The check for calling free_page() on hv_context.synic_event_page[cpu] is the
same for hv_context.synic_message_page[cpu], like a copy-paste error.

Signed-off-by: Felipe Pena <[email protected]>
---
drivers/hv/hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 88f4096..f0c5e07 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -304,7 +304,7 @@ err:
void hv_synic_free_cpu(int cpu)
{
kfree(hv_context.event_dpc[cpu]);
- if (hv_context.synic_message_page[cpu])
+ if (hv_context.synic_event_page[cpu])
free_page((unsigned long)hv_context.synic_event_page[cpu]);
if (hv_context.synic_message_page[cpu])
free_page((unsigned long)hv_context.synic_message_page[cpu]);
--
1.7.10.4

2013-10-15 23:32:16

by KY Srinivasan

Subject: RE: [PATCH 1/1] drivers: hv: Fix wrong check for synic_event_page

> -----Original Message-----
> From: Felipe Pena [mailto:[email protected]]
> Sent: Tuesday, October 15, 2013 4:23 PM
> To: KY Srinivasan; Haiyang Zhang
> Cc: [email protected]; [email protected]; Felipe Pena
> Subject: [PATCH 1/1] drivers: hv: Fix wrong check for synic_event_page
>
> The check for calling free_page() on hv_context.synic_event_page[cpu] is the
> same for hv_context.synic_message_page[cpu], like a copy-paste error.
>
> Signed-off-by: Felipe Pena <[email protected]>

Thanks Felipe.

Signed-off-by: K. Y. Srinivasan <[email protected]>

K. Y


> ---
> drivers/hv/hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index 88f4096..f0c5e07 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -304,7 +304,7 @@ err:
> void hv_synic_free_cpu(int cpu)
> {
> kfree(hv_context.event_dpc[cpu]);
> - if (hv_context.synic_message_page[cpu])
> + if (hv_context.synic_event_page[cpu])
> free_page((unsigned long)hv_context.synic_event_page[cpu]);
> if (hv_context.synic_message_page[cpu])
> free_page((unsigned
> long)hv_context.synic_message_page[cpu]);
> --
> 1.7.10.4