2013-10-21 08:01:41

by Michael Opdenacker

Subject: [PATCH] hfs: remove duplicate includes

This patch removes duplicate includes from fs/hfs/btree.h

Signed-off-by: Michael Opdenacker <[email protected]>
---
fs/hfs/btree.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/fs/hfs/btree.h b/fs/hfs/btree.h
index 2a1d712..f6bd266 100644
--- a/fs/hfs/btree.h
+++ b/fs/hfs/btree.h
@@ -153,11 +153,6 @@ struct hfs_btree_header_rec {
u32 reserved3[16];
} __packed;

-#define HFS_NODE_INDEX 0x00 /* An internal (index) node */
-#define HFS_NODE_HEADER 0x01 /* The tree header node (node 0) */
-#define HFS_NODE_MAP 0x02 /* Holds part of the bitmap of used nodes */
-#define HFS_NODE_LEAF 0xFF /* A leaf (ndNHeight==1) node */
-
#define BTREE_ATTR_BADCLOSE 0x00000001 /* b-tree not closed properly. not
used by hfsplus. */
#define HFS_TREE_BIGKEYS 0x00000002 /* key length is u16 instead of u8.
--
1.8.1.2

2013-10-21 08:17:04

by Viacheslav Dubeyko

Subject: Re: [PATCH] hfs: remove duplicate includes

On Mon, 2013-10-21 at 10:01 +0200, Michael Opdenacker wrote:
> This patch removes duplicate includes from fs/hfs/btree.h
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---
> fs/hfs/btree.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/hfs/btree.h b/fs/hfs/btree.h
> index 2a1d712..f6bd266 100644
> --- a/fs/hfs/btree.h
> +++ b/fs/hfs/btree.h
> @@ -153,11 +153,6 @@ struct hfs_btree_header_rec {
> u32 reserved3[16];
> } __packed;
>
> -#define HFS_NODE_INDEX 0x00 /* An internal (index) node */
> -#define HFS_NODE_HEADER 0x01 /* The tree header node (node 0) */
> -#define HFS_NODE_MAP 0x02 /* Holds part of the bitmap of used nodes */
> -#define HFS_NODE_LEAF 0xFF /* A leaf (ndNHeight==1) node */
> -

Yes, it is really duplicate declarations.

Thank you for cleanup.

Reviewed-by: Vyacheslav Dubeyko <[email protected]>

Thanks,
Vyacheslav Dubeyko.

> #define BTREE_ATTR_BADCLOSE 0x00000001 /* b-tree not closed properly. not
> used by hfsplus. */
> #define HFS_TREE_BIGKEYS 0x00000002 /* key length is u16 instead of u8.