2013-10-22 22:36:03

by Kent Overstreet

Subject: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset()

Signed-off-by: Kent Overstreet <[email protected]>
Cc: linux-stable <[email protected]> # >= v3.10
---
drivers/md/bcache/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
index b6a74bc..2a7f0dd 100644
--- a/drivers/md/bcache/request.c
+++ b/drivers/md/bcache/request.c
@@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)

if (bio->bi_rw & REQ_FLUSH) {
/* Also need to send a flush to the backing device */
- struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
+ struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
dc->disk.bio_split);

flush->bi_rw = WRITE_FLUSH;
--
1.8.4.rc3

2013-10-24 12:04:11

by Jens Axboe

Subject: Re: [PATCH] bcache: Fixed incorrect order of arguments to bio_alloc_bioset()

On Tue, Oct 22 2013, Kent Overstreet wrote:
> Signed-off-by: Kent Overstreet <[email protected]>
> Cc: linux-stable <[email protected]> # >= v3.10
> ---
> drivers/md/bcache/request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index b6a74bc..2a7f0dd 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -1000,7 +1000,7 @@ static void request_write(struct cached_dev *dc, struct search *s)
>
> if (bio->bi_rw & REQ_FLUSH) {
> /* Also need to send a flush to the backing device */
> - struct bio *flush = bio_alloc_bioset(0, GFP_NOIO,
> + struct bio *flush = bio_alloc_bioset(GFP_NOIO, 0,
> dc->disk.bio_split);
>
> flush->bi_rw = WRITE_FLUSH;

Woops... Added.

--
Jens Axboe