2013-10-24 05:38:32

by Johannes Löthberg

Subject: [PATCH 0/2] Staging: vt6656: fix two coding style issues

This patchset fixes two coding style issues reported by checkpatch.pl in
drivers/staging/vt6656, one warning and one error

Johannes Löthberg (2):
Staging: vt6656: fix a brace coding style issue in power.c
Staging: vt6656: fix code indenting error in power.c

drivers/staging/vt6656/power.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

--
1.8.4.1

2013-10-24 05:38:21

by Johannes Löthberg

Subject: [PATCH 2/2] Staging: vt6656: fix code indenting error in power.c

This patch fixes a code indentation error found by checkpatch.pl
where a line was indented with spaces instead of tabs

Signed-off-by: Johannes Löthberg <[email protected]>
---
drivers/staging/vt6656/power.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
index 3002061..a14a2bf 100644
--- a/drivers/staging/vt6656/power.c
+++ b/drivers/staging/vt6656/power.c
@@ -268,7 +268,7 @@ int PSbSendNullPacket(struct vnt_private *pDevice)
+ sizeof(struct vnt_tx_mgmt));

flags = WLAN_SET_FC_FTYPE(WLAN_TYPE_DATA) |
- WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
+ WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);

if (pDevice->bEnablePSMode)
flags |= WLAN_SET_FC_PWRMGT(1);
--
1.8.4.1

2013-10-24 05:38:28

by Johannes Löthberg

Subject: [PATCH 1/2] Staging: vt6656: fix a brace coding style issue in power.c

This patch fixes a brace warning in power.c found by checkpatch.pl

Signed-off-by: Johannes Löthberg <[email protected]>
---
drivers/staging/vt6656/power.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
index edc8975..3002061 100644
--- a/drivers/staging/vt6656/power.c
+++ b/drivers/staging/vt6656/power.c
@@ -233,9 +233,8 @@ void PSvSendPSPOLL(struct vnt_private *pDevice)
pTxPacket->cbPayloadLen = 0;

/* log failure if sending failed */
- if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING) {
+ if (csMgmt_xmit(pDevice, pTxPacket) != CMD_STATUS_PENDING)
DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "Send PS-Poll packet failed..\n");
- }
}

/*
--
1.8.4.1

2013-10-27 13:51:56

by Greg Kroah-Hartman

Subject: Re: [PATCH 2/2] Staging: vt6656: fix code indenting error in power.c

On Thu, Oct 24, 2013 at 07:26:47AM +0200, Johannes L?thberg wrote:
> This patch fixes a code indentation error found by checkpatch.pl
> where a line was indented with spaces instead of tabs
>
> Signed-off-by: Johannes L?thberg <[email protected]>
> ---
> drivers/staging/vt6656/power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/power.c b/drivers/staging/vt6656/power.c
> index 3002061..a14a2bf 100644
> --- a/drivers/staging/vt6656/power.c
> +++ b/drivers/staging/vt6656/power.c
> @@ -268,7 +268,7 @@ int PSbSendNullPacket(struct vnt_private *pDevice)
> + sizeof(struct vnt_tx_mgmt));
>
> flags = WLAN_SET_FC_FTYPE(WLAN_TYPE_DATA) |
> - WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);
> + WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_NULL);

No, indent this line properly using tabs to where the spaces were,
that's the correct location.

greg k-h