2014-01-06 08:31:16

by Ramkumar Ramachandra

[permalink] [raw]
Subject: [PATCH] Documentation: add ABI entry for intel_pstate

Add a Documentation/ABI entry for
/sys/devices/system/cpu/intel_pstate/max_perf_pct,
/sys/devices/system/cpu/intel_pstate/min_perf_pct, and
/sys/devices/system/cpu/intel_pstate/no_turbo.

Cc: Dirk Brandewie <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Linux PM <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
Documentation/ABI/testing/sysfs-devices-system-cpu | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
index 468e4d4..7080718 100644
--- a/Documentation/ABI/testing/sysfs-devices-system-cpu
+++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
@@ -200,3 +200,18 @@ Description: address and size of the percpu note.
note of cpu#.

crash_notes_size: size of the note of cpu#.
+
+
+What: /sys/devices/system/cpu/intel_pstate/max_perf_pct
+ /sys/devices/system/cpu/intel_pstate/min_perf_pct
+ /sys/devices/system/cpu/intel_pstate/no_turbo
+Date: February 2013
+Contact: [email protected]
+Description: Parameters for the Intel P-state driver
+
+ Logic for selecting the current P-state in Intel
+ Sandybridge+ processors. The three knobs control
+ limits for the P-state that will be requested by the
+ driver.
+
+ More details can be found in Documentation/cpu-freq/intel-pstate.txt
--
1.8.5.2.227.g53f3478


2014-01-06 11:09:37

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH] Documentation: add ABI entry for intel_pstate

On Monday, January 06, 2014 02:01:17 PM Ramkumar Ramachandra wrote:
> Add a Documentation/ABI entry for
> /sys/devices/system/cpu/intel_pstate/max_perf_pct,
> /sys/devices/system/cpu/intel_pstate/min_perf_pct, and
> /sys/devices/system/cpu/intel_pstate/no_turbo.
>
> Cc: Dirk Brandewie <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Linux PM <[email protected]>
> Signed-off-by: Ramkumar Ramachandra <[email protected]>
> ---
> Documentation/ABI/testing/sysfs-devices-system-cpu | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> index 468e4d4..7080718 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> @@ -200,3 +200,18 @@ Description: address and size of the percpu note.
> note of cpu#.
>
> crash_notes_size: size of the note of cpu#.
> +
> +
> +What: /sys/devices/system/cpu/intel_pstate/max_perf_pct
> + /sys/devices/system/cpu/intel_pstate/min_perf_pct
> + /sys/devices/system/cpu/intel_pstate/no_turbo

Well, can you please describe each of them separately? Like what each of them
actually does?

> +Date: February 2013
> +Contact: [email protected]
> +Description: Parameters for the Intel P-state driver
> +
> + Logic for selecting the current P-state in Intel
> + Sandybridge+ processors. The three knobs control
> + limits for the P-state that will be requested by the
> + driver.
> +
> + More details can be found in Documentation/cpu-freq/intel-pstate.txt

No, that's not enough.

Thanks!

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

2014-01-06 12:54:25

by Ramkumar Ramachandra

[permalink] [raw]
Subject: [PATCH v2] Documentation: add ABI entry for intel_pstate

Add a Documentation/ABI entry for
/sys/devices/system/cpu/intel_pstate/max_perf_pct,
/sys/devices/system/cpu/intel_pstate/min_perf_pct, and
/sys/devices/system/cpu/intel_pstate/no_turbo.

Cc: Dirk Brandewie <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Linux PM <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
Documentation/ABI/testing/sysfs-devices-system-cpu | 24 ++++++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
index 468e4d4..d5a0d33 100644
--- a/Documentation/ABI/testing/sysfs-devices-system-cpu
+++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
@@ -200,3 +200,27 @@ Description: address and size of the percpu note.
note of cpu#.

crash_notes_size: size of the note of cpu#.
+
+
+What: /sys/devices/system/cpu/intel_pstate/max_perf_pct
+ /sys/devices/system/cpu/intel_pstate/min_perf_pct
+ /sys/devices/system/cpu/intel_pstate/no_turbo
+Date: February 2013
+Contact: [email protected]
+Description: Parameters for the Intel P-state driver
+
+ Logic for selecting the current P-state in Intel
+ Sandybridge+ processors. The three knobs control
+ limits for the P-state that will be requested by the
+ driver.
+
+ max_perf_pct: limits the maximum P state that will be requested by
+ the driver stated as a percentage of the available performance.
+
+ min_perf_pct: limits the minimum P state that will be requested by
+ the driver stated as a percentage of the available performance.
+
+ no_turbo: limits the driver to selecting P states below the turbo
+ frequency range.
+
+ More details can be found in Documentation/cpu-freq/intel-pstate.txt
--
1.8.5.2.227.g53f3478

2014-01-06 14:19:23

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v2] Documentation: add ABI entry for intel_pstate

On Monday, January 06, 2014 06:24:26 PM Ramkumar Ramachandra wrote:
> Add a Documentation/ABI entry for
> /sys/devices/system/cpu/intel_pstate/max_perf_pct,
> /sys/devices/system/cpu/intel_pstate/min_perf_pct, and
> /sys/devices/system/cpu/intel_pstate/no_turbo.
>
> Cc: Dirk Brandewie <[email protected]>
> Cc: Rafael J. Wysocki <[email protected]>
> Cc: Randy Dunlap <[email protected]>
> Cc: Linux PM <[email protected]>
> Signed-off-by: Ramkumar Ramachandra <[email protected]>

OK, queued up for 3.14.

Thanks!

> ---
> Documentation/ABI/testing/sysfs-devices-system-cpu | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-system-cpu b/Documentation/ABI/testing/sysfs-devices-system-cpu
> index 468e4d4..d5a0d33 100644
> --- a/Documentation/ABI/testing/sysfs-devices-system-cpu
> +++ b/Documentation/ABI/testing/sysfs-devices-system-cpu
> @@ -200,3 +200,27 @@ Description: address and size of the percpu note.
> note of cpu#.
>
> crash_notes_size: size of the note of cpu#.
> +
> +
> +What: /sys/devices/system/cpu/intel_pstate/max_perf_pct
> + /sys/devices/system/cpu/intel_pstate/min_perf_pct
> + /sys/devices/system/cpu/intel_pstate/no_turbo
> +Date: February 2013
> +Contact: [email protected]
> +Description: Parameters for the Intel P-state driver
> +
> + Logic for selecting the current P-state in Intel
> + Sandybridge+ processors. The three knobs control
> + limits for the P-state that will be requested by the
> + driver.
> +
> + max_perf_pct: limits the maximum P state that will be requested by
> + the driver stated as a percentage of the available performance.
> +
> + min_perf_pct: limits the minimum P state that will be requested by
> + the driver stated as a percentage of the available performance.
> +
> + no_turbo: limits the driver to selecting P states below the turbo
> + frequency range.
> +
> + More details can be found in Documentation/cpu-freq/intel-pstate.txt
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.