2014-01-06 16:23:26

by Ramkumar Ramachandra

[permalink] [raw]
Subject: [PATCH 0/3] cpupower tools: trivial cleanup

Hi,

I just had a chance to look at cpupower; here's a small contribution.

Thanks.

Cc: Thomas Renninger <[email protected]>
Cc: Dominik Brodowski <[email protected]>

Ramkumar Ramachandra (3):
cpupower tools: adjust README to reflect rename
cpupower tools: update README
cpupower tools: update uninstall target

tools/power/cpupower/Makefile | 8 ++++++--
tools/power/cpupower/README | 24 +++++++++++-------------
tools/power/cpupower/ToDo | 1 -
3 files changed, 17 insertions(+), 16 deletions(-)

--
1.8.5.2.227.g53f3478


2014-01-06 16:23:32

by Ramkumar Ramachandra

[permalink] [raw]
Subject: [PATCH 2/3] cpupower tools: update README

Remove dead link to homepage, and update the targets built.

Cc: Thomas Renninger <[email protected]>
Cc: Dominik Brodowski <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
tools/power/cpupower/README | 16 +++++++---------
tools/power/cpupower/ToDo | 1 -
2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/tools/power/cpupower/README b/tools/power/cpupower/README
index 96ff1ff..1c68f47 100644
--- a/tools/power/cpupower/README
+++ b/tools/power/cpupower/README
@@ -1,6 +1,4 @@
-The cpupower package (homepage:
-http://www.kernel.org/pub/linux/utils/kernel/cpufreq/cpufrequtils.html )
-consists of the following elements:
+The cpupower package consists of the following elements:

requirements
------------
@@ -28,12 +26,12 @@ make
su
make install

-should suffice on most systems. It builds default libcpupower,
-cpufreq-set and cpufreq-info files and installs them in /usr/lib and
-/usr/bin, respectively. If you want to set up the paths differently and/or
-want to configure the package to your specific needs, you need to open
-"Makefile" with an editor of your choice and edit the block marked
-CONFIGURATION.
+should suffice on most systems. It builds libcpupower to put in
+/usr/lib; cpupower, cpufreq-bench_plot.sh to put in /usr/bin; and
+cpufreq-bench to put in /usr/sbin. If you want to set up the paths
+differently and/or want to configure the package to your specific
+needs, you need to open "Makefile" with an editor of your choice and
+edit the block marked CONFIGURATION.


THANKS
diff --git a/tools/power/cpupower/ToDo b/tools/power/cpupower/ToDo
index 874b78b..6e8b89f 100644
--- a/tools/power/cpupower/ToDo
+++ b/tools/power/cpupower/ToDo
@@ -3,7 +3,6 @@ ToDos sorted by priority:
- Use bitmask functions to parse CPU topology more robust
(current implementation has issues on AMD)
- Try to read out boost states and frequencies on Intel
-- Adjust README
- Somewhere saw the ability to read power consumption of
RAM from HW on Intel SandyBridge -> another monitor?
- Add another c1e debug idle monitor
--
1.8.5.2.227.g53f3478

2014-01-06 16:24:05

by Ramkumar Ramachandra

[permalink] [raw]
Subject: [PATCH 3/3] cpupower tools: update uninstall target

Cc: Thomas Renninger <[email protected]>
Cc: Dominik Brodowski <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
tools/power/cpupower/Makefile | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
index cbfec92..dca6b43 100644
--- a/tools/power/cpupower/Makefile
+++ b/tools/power/cpupower/Makefile
@@ -295,8 +295,12 @@ uninstall:
- rm -f $(DESTDIR)${libdir}/libcpupower.*
- rm -f $(DESTDIR)${includedir}/cpufreq.h
- rm -f $(DESTDIR)${bindir}/utils/cpupower
- - rm -f $(DESTDIR)${mandir}/man1/cpufreq-set.1
- - rm -f $(DESTDIR)${mandir}/man1/cpufreq-info.1
+ - rm -f $(DESTDIR)${mandir}/man1/cpupower.1
+ - rm -f $(DESTDIR)${mandir}/man1/cpupower-frequency-set.1
+ - rm -f $(DESTDIR)${mandir}/man1/cpupower-frequency-info.1
+ - rm -f $(DESTDIR)${mandir}/man1/cpupower-set.1
+ - rm -f $(DESTDIR)${mandir}/man1/cpupower-info.1
+ - rm -f $(DESTDIR)${mandir}/man1/cpupower-monitor.1
- for HLANG in $(LANGUAGES); do \
rm -f $(DESTDIR)${localedir}/$$HLANG/LC_MESSAGES/cpupower.mo; \
done;
--
1.8.5.2.227.g53f3478

2014-01-06 16:24:40

by Ramkumar Ramachandra

[permalink] [raw]
Subject: [PATCH 1/3] cpupower tools: adjust README to reflect rename

Rename cpufrequtils -> cpupower, and libcpufreq -> libcpupower.

Cc: Thomas Renninger <[email protected]>
Cc: Dominik Brodowski <[email protected]>
Signed-off-by: Ramkumar Ramachandra <[email protected]>
---
tools/power/cpupower/README | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/power/cpupower/README b/tools/power/cpupower/README
index fd9d4c0..96ff1ff 100644
--- a/tools/power/cpupower/README
+++ b/tools/power/cpupower/README
@@ -1,4 +1,4 @@
-The cpufrequtils package (homepage:
+The cpupower package (homepage:
http://www.kernel.org/pub/linux/utils/kernel/cpufreq/cpufrequtils.html )
consists of the following elements:

@@ -11,10 +11,10 @@ providing cpuid.h is needed.
For both it's not explicitly checked for (yet).


-libcpufreq
+libcpupower
----------

-"libcpufreq" is a library which offers a unified access method for userspace
+"libcpupower" is a library which offers a unified access method for userspace
tools and programs to the cpufreq core and drivers in the Linux kernel. This
allows for code reduction in userspace tools, a clean implementation of
the interaction to the cpufreq core, and support for both the sysfs and proc
@@ -28,7 +28,7 @@ make
su
make install

-should suffice on most systems. It builds default libcpufreq,
+should suffice on most systems. It builds default libcpupower,
cpufreq-set and cpufreq-info files and installs them in /usr/lib and
/usr/bin, respectively. If you want to set up the paths differently and/or
want to configure the package to your specific needs, you need to open
@@ -39,11 +39,11 @@ CONFIGURATION.
THANKS
------
Many thanks to Mattia Dongili who wrote the autotoolization and
-libtoolization, the manpages and the italian language file for cpufrequtils;
+libtoolization, the manpages and the italian language file for cpupower;
to Dave Jones for his feedback and his dump_psb tool; to Bruno Ducrot for his
powernow-k8-decode and intel_gsic tools as well as the french language file;
and to various others commenting on the previous (pre-)releases of
-cpufrequtils.
+cpupower.


Dominik Brodowski
--
1.8.5.2.227.g53f3478