On Tue, 2013-12-24 at 16:02 +0100, Manfred Spraul wrote:
> The ipc code does not adhere the typical linux coding style.
> This patch fixes lots of simple whitespace errors.
While it's no big deal, the title of the patch doesn't really reflect
the actual changes as it deals with much more than just whitespace
cleanups. How about something like "ipc: checkpatch fixes"?
>
> - mostly autogenerated by
> scripts/checkpatch.pl -f --fix \
> --types=pointer_location,spacing,space_before_tab
> - one manual fixup (keep structure members tab-aligned)
> - removal of additional space_before_tab that were not found by --fix
>
> diff -w is empty.
> Tested with some of my msg and sem test apps.
>
> Andrew: Could you include it in -mm and move it towards Linus' tree?
This patch doesn't apply on top of linux-next (which now includes
Rafael's changes), could you please resend? I'm planning some more
cleanups on top of this so, if Andrew agrees, I can include these
changes to my patchset.
Thanks,
Davidlohr
On Tue, 2014-01-07 at 09:12 -0800, Davidlohr Bueso wrote:
> On Tue, 2013-12-24 at 16:02 +0100, Manfred Spraul wrote:
> > The ipc code does not adhere the typical linux coding style.
> > This patch fixes lots of simple whitespace errors.
>
> While it's no big deal, the title of the patch doesn't really reflect
> the actual changes as it deals with much more than just whitespace
> cleanups. How about something like "ipc: checkpatch fixes"?
Isn't a patch where "git diff -w" is empty
whitespace only cleanups?
$ git diff --help
[]
-w, --ignore-all-space
Ignore whitespace when comparing lines. This ignores differences
even if one line has whitespace where the other line has none.
On Tue, 2014-01-07 at 09:24 -0800, Joe Perches wrote:
> On Tue, 2014-01-07 at 09:12 -0800, Davidlohr Bueso wrote:
> > On Tue, 2013-12-24 at 16:02 +0100, Manfred Spraul wrote:
> > > The ipc code does not adhere the typical linux coding style.
> > > This patch fixes lots of simple whitespace errors.
> >
> > While it's no big deal, the title of the patch doesn't really reflect
> > the actual changes as it deals with much more than just whitespace
> > cleanups. How about something like "ipc: checkpatch fixes"?
>
> Isn't a patch where "git diff -w" is empty
> whitespace only cleanups?
>
> $ git diff --help
> []
> -w, --ignore-all-space
> Ignore whitespace when comparing lines. This ignores differences
> even if one line has whitespace where the other line has none.
>
Ok, sorry about the noise then, I just didn't consider foo () >> foo() a
whitespace cleanup.