2014-01-09 08:31:39

by panchaxari

[permalink] [raw]
Subject: [PATCH CFT] ARM:SHMOBILE: Enable AUTO_ZRELADDR by default

This patch enables AUTO_ZRELADDR as default config to Renasas R-Mobile and
SH-Mobile platforms.

AUTO_ZRELADDR config enables auto calculation of the decompressed kernel image
address. AUTO_ZRELADDR config is mutually exclusive to ZBOOT_ROM, and also
assumes zImage to be loaded in the first 128MiB from start of memory.

CFT::Call For Testing

Requesting maintainers of R-Mobile and SH-Mobile platforms to evaluate the
changes on the board and comment, as I dont have the board for testing, and
also requesting an ACK.

Signed-off-by: panchaxari <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Simon Horman <[email protected]>
Cc: Magnus Damm <[email protected]>
Cc: Russell King <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Below lkml link is a quoting by Russell which clears the concept of PHYS_VIRT
and ZRELADDR
---------------------------------------------------

https://lkml.org/lkml/2011/10/14/434

-------------------------------------------------
---
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 8e668e2..077ef9d 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -674,6 +674,7 @@ config ARCH_MSM
config ARCH_SHMOBILE
bool "Renesas SH-Mobile / R-Mobile"
select ARM_PATCH_PHYS_VIRT
+ select AUTO_ZRELADDR
select CLKDEV_LOOKUP
select GENERIC_CLOCKEVENTS
select HAVE_ARM_SCU if SMP
--
1.7.10.4


2014-01-09 08:45:05

by Magnus Damm

[permalink] [raw]
Subject: Re: [PATCH CFT] ARM:SHMOBILE: Enable AUTO_ZRELADDR by default

On Thu, Jan 9, 2014 at 5:31 PM, panchaxari
<[email protected]> wrote:
> This patch enables AUTO_ZRELADDR as default config to Renasas R-Mobile and
> SH-Mobile platforms.
>
> AUTO_ZRELADDR config enables auto calculation of the decompressed kernel image
> address. AUTO_ZRELADDR config is mutually exclusive to ZBOOT_ROM, and also
> assumes zImage to be loaded in the first 128MiB from start of memory.
>
> CFT::Call For Testing
>
> Requesting maintainers of R-Mobile and SH-Mobile platforms to evaluate the
> changes on the board and comment, as I dont have the board for testing, and
> also requesting an ACK.
>
> Signed-off-by: panchaxari <[email protected]>

Thanks for the patch. I believe we enable this for the multiplatform
case already. The legacy case still supports ZBOOT_ROM and boards that
don't work with AUTO_ZRELADDR, so because of this we intentionally
don't enable it there.

What is the reason you want to add it here?

Thanks,

/ magnus

2014-01-09 08:51:36

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH CFT] ARM:SHMOBILE: Enable AUTO_ZRELADDR by default

This patch does not enable AUTO_ZRELADDR by default.
It forces AUTO_ZRELADDR to be enabled to be used unless ZBOOT_ROM is enabled.

I'm not opposed to this approach but I think the changelog is misleading.


AUTO_ZRELADDR is known to work on the Genmai, Koelsch, KZM9D and Lager
boards and is enabled in their defconfigs.

I will defer to Magnus on weather he is comfortable with being
enable globally for shmobile but if not perhaps it could be selected
on a per-board or per-SoC basis.

On Thu, Jan 09, 2014 at 02:01:14PM +0530, panchaxari wrote:
> This patch enables AUTO_ZRELADDR as default config to Renasas R-Mobile and
> SH-Mobile platforms.
>
> AUTO_ZRELADDR config enables auto calculation of the decompressed kernel image
> address. AUTO_ZRELADDR config is mutually exclusive to ZBOOT_ROM, and also
> assumes zImage to be loaded in the first 128MiB from start of memory.
>
> CFT::Call For Testing
>
> Requesting maintainers of R-Mobile and SH-Mobile platforms to evaluate the
> changes on the board and comment, as I dont have the board for testing, and
> also requesting an ACK.
>
> Signed-off-by: panchaxari <[email protected]>

Please use your first name and last name in the From address and
Signed-off-by line.

e.g.

Signed-off-by: Panchaxari Prasannamurthy <[email protected]>

> Cc: Laurent Pinchart <[email protected]>
> Cc: Simon Horman <[email protected]>
> Cc: Magnus Damm <[email protected]>
> Cc: Russell King <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Below lkml link is a quoting by Russell which clears the concept of PHYS_VIRT
> and ZRELADDR
> ---------------------------------------------------
>
> https://lkml.org/lkml/2011/10/14/434
>
> -------------------------------------------------
> ---
> arch/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 8e668e2..077ef9d 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -674,6 +674,7 @@ config ARCH_MSM
> config ARCH_SHMOBILE
> bool "Renesas SH-Mobile / R-Mobile"
> select ARM_PATCH_PHYS_VIRT
> + select AUTO_ZRELADDR
> select CLKDEV_LOOKUP
> select GENERIC_CLOCKEVENTS
> select HAVE_ARM_SCU if SMP
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2014-01-09 10:03:33

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH CFT] ARM:SHMOBILE: Enable AUTO_ZRELADDR by default

On Thu, Jan 09, 2014 at 02:01:14PM +0530, panchaxari wrote:
> This patch enables AUTO_ZRELADDR as default config to Renasas R-Mobile and
> SH-Mobile platforms.

NAK.

--
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".