2014-01-10 04:06:44

by Chase Southwood

Subject: [PATCH] Staging: comedi: fix spacing coding style issue in 8255.c.

This patch for 8255.c fixes a spacing warning found by checkpatch.pl.

Signed-off-by: Chase Southwood <[email protected]>
---
drivers/staging/comedi/drivers/8255.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
index b4009e8..48817f0 100644
--- a/drivers/staging/comedi/drivers/8255.c
+++ b/drivers/staging/comedi/drivers/8255.c
@@ -94,7 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.

struct subdev_8255_private {
unsigned long iobase;
- int (*io) (int, int, int, unsigned long);
+ int (*io)(int, int, int, unsigned long);
};

static int subdev_8255_io(int dir, int port, int data, unsigned long iobase)
@@ -262,7 +262,7 @@ static int subdev_8255_cancel(struct comedi_device *dev,
}

int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,
- int (*io) (int, int, int, unsigned long),
+ int (*io)(int, int, int, unsigned long),
unsigned long iobase)
{
struct subdev_8255_private *spriv;
@@ -289,7 +289,7 @@ int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,
EXPORT_SYMBOL_GPL(subdev_8255_init);

int subdev_8255_init_irq(struct comedi_device *dev, struct comedi_subdevice *s,
- int (*io) (int, int, int, unsigned long),
+ int (*io)(int, int, int, unsigned long),
unsigned long iobase)
{
int ret;
--
1.8.4.2

2014-01-10 10:34:10

by Ian Abbott

Subject: Re: [PATCH] Staging: comedi: fix spacing coding style issue in 8255.c.

On 2014-01-10 03:59, Chase Southwood wrote:
> This patch for 8255.c fixes a spacing warning found by checkpatch.pl.
>
> Signed-off-by: Chase Southwood <[email protected]>
> ---
> drivers/staging/comedi/drivers/8255.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
> index b4009e8..48817f0 100644
> --- a/drivers/staging/comedi/drivers/8255.c
> +++ b/drivers/staging/comedi/drivers/8255.c
> @@ -94,7 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.
>
> struct subdev_8255_private {
> unsigned long iobase;
> - int (*io) (int, int, int, unsigned long);
> + int (*io)(int, int, int, unsigned long);
> };
>
> static int subdev_8255_io(int dir, int port, int data, unsigned long iobase)
> @@ -262,7 +262,7 @@ static int subdev_8255_cancel(struct comedi_device *dev,
> }
>
> int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,
> - int (*io) (int, int, int, unsigned long),
> + int (*io)(int, int, int, unsigned long),
> unsigned long iobase)
> {
> struct subdev_8255_private *spriv;
> @@ -289,7 +289,7 @@ int subdev_8255_init(struct comedi_device *dev, struct comedi_subdevice *s,
> EXPORT_SYMBOL_GPL(subdev_8255_init);
>
> int subdev_8255_init_irq(struct comedi_device *dev, struct comedi_subdevice *s,
> - int (*io) (int, int, int, unsigned long),
> + int (*io)(int, int, int, unsigned long),
> unsigned long iobase)
> {
> int ret;
>

Harmless. (Good!)

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-