2014-01-10 08:21:53

by Sergei Trofimovich

Subject: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE

config: make ARCH=avr32 mimc200_defconfig

> All error/warnings:
>
> arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
> arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
> arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype

Untested.

Reported-by: kbuild test robot <[email protected]>
CC: Mark Jackson <[email protected]>
CC: Hans-Christian Egtvedt <[email protected]>
CC: Haavard Skinnemoen <[email protected]>
Signed-off-by: Sergei Trofimovich <[email protected]>
---
arch/avr32/boards/mimc200/fram.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
index 9764a1a..76cb51d 100644
--- a/arch/avr32/boards/mimc200/fram.c
+++ b/arch/avr32/boards/mimc200/fram.c
@@ -13,6 +13,7 @@
#include <linux/miscdevice.h>
#include <linux/proc_fs.h>
#include <linux/mm.h>
+#include <linux/module.h>
#include <linux/io.h>

#define FRAM_BASE 0xac000000
--
1.8.5.2

2014-01-12 17:16:19

by Hans-Christian Noren Egtvedt

Subject: Re: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h' for MODULE_LICENSE

Around Fri 10 Jan 2014 11:16:14 +0300 or thereabout, Sergei Trofimovich wrote:
> config: make ARCH=avr32 mimc200_defconfig
>
>> All error/warnings:
>>
>> arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
>> arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
>> arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
>> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype
>
> Untested.

Looks very sane.

> Reported-by: kbuild test robot <[email protected]>
> CC: Mark Jackson <[email protected]>
> CC: Hans-Christian Egtvedt <[email protected]>
> CC: Haavard Skinnemoen <[email protected]>
> Signed-off-by: Sergei Trofimovich <[email protected]>

Acked-by: Hans-Christian Egtvedt <[email protected]>

> ---
> arch/avr32/boards/mimc200/fram.c | 1 +
> 1 file changed, 1 insertion(+)

I will append this to the AVR32 tree at git.kernel.org.

> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a..76cb51d 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -13,6 +13,7 @@
> #include <linux/miscdevice.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> +#include <linux/module.h>
> #include <linux/io.h>
>
> #define FRAM_BASE 0xac000000
--
mvh
Hans-Christian Egtvedt