2014-01-11 04:14:24

by Chase Southwood

Subject: [PATCH 0/3] Staging: comedi: Checkpatch cleanups in ni_mio_common.c

This patch series fixes several warnings reported by checkpatch.pl in ni_mio_common.c of the comedi driver.

Among the issues fixed:
*Many unnecessary braces have been removed.
*Improper indentation has been corrected.
*Extra whitespace before semicolons has been removed.
*Extra whitespace after function pointer name has been removed.

Several checkpatch warnings still remain (mainly 80 character+ line lengths), but no new warnings have been introduced, and no functionality changes have been made.

2014-01-11 05:49:58

by Chase Southwood

Subject: Re: [PATCH 0/3] Staging: comedi: Checkpatch cleanups in ni_mio_common.c

Oops, left out some of my cover letter. Here is the amended patchset
cover letter.

On Fri, Jan 10, 2014 at 10:07 PM, Chase Southwood
<[email protected]> wrote:
>
> This patch series fixes several warnings reported by checkpatch.pl in ni_mio_common.c of the comedi driver.
>
> Among the issues fixed:
> *Many unnecessary braces have been removed.
> *Improper indentation has been corrected.
> *Extra whitespace before semicolons has been removed.
> *Extra whitespace after function pointer name has been removed.
>
> Several checkpatch warnings still remain (mainly 80 character+ line lengths), but no new warnings have been introduced, and no functionality changes have been made.
>

Chase Southwood (3):
Staging: comedi: fix numerous brace coding style issues in ni_mio_common.c.
Staging: comedi: fix indentation coding style issue in ni_mio_common.c.
Staging: comedi: fix extra whitespace style issues in ni_mio_common.c.

drivers/staging/comedi/drivers/ni_mio_common.c | 138 +++++++++----------------
1 file changed, 50 insertions(+), 88 deletions(-)

2014-01-13 10:07:35

by Ian Abbott

Subject: Re: [PATCH 0/3] Staging: comedi: Checkpatch cleanups in ni_mio_common.c

On 2014-01-11 03:56, Chase Southwood wrote:
> This patch series fixes several warnings reported by checkpatch.pl in
> ni_mio_common.c of the comedi driver.
>
> Among the issues fixed:
> *Many unnecessary braces have been removed.
> *Improper indentation has been corrected.
> *Extra whitespace before semicolons has been removed.
> *Extra whitespace after function pointer name has been removed.
>
> Several checkpatch warnings still remain (mainly 80 character+ line
> lengths), but no new warnings have been introduced, and no functionality
> changes have been made.

All three patches are nice and harmless.

Reviewed-by: Ian Abbott <[email protected]>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-