2014-01-13 20:14:54

by Joe Borg

[permalink] [raw]
Subject: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

Signed-off-by Joe Borg <[email protected]>
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++ b/drivers/staging/comedi/drivers/das1800.c
@@ -462,7 +462,7 @@ static inline uint16_t munge_bipolar_sample(const struct comedi_device *dev,
return sample;
}

-static void munge_data(struct comedi_device *dev, uint16_t * array,
+static void munge_data(struct comedi_device *dev, uint16_t *array,
unsigned int num_elements)
{
unsigned int i;
--
1.8.5.2


2014-01-13 21:08:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

On Mon, Jan 13, 2014 at 08:14:46PM +0000, Joe Borg wrote:
> Signed-off-by Joe Borg <[email protected]>

You need a changelog comment here, please.

And is that your "real" email address and name?

greg k-h

2014-01-13 21:33:39

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

On Mon, Jan 13, 2014 at 09:23:11PM +0000, Joe Borġ wrote:
> Ok, will do the change log.
>
> Yes, it's my real name and email... I know the email address is embarrassing,
> but genuine :).
>
>
>
> Regards,
> Joseph David Borġ

There's nothing wrong with using "Joe Borġ" as your signed-off-by: line,
as that's your real name :)

thanks,

greg k-h