2014-01-14 21:28:53

by Michał Kwiatkowski

Subject: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

From: Michal Kwiatkowski <[email protected]>

This is a patch to the alarm-dev.c file that removes parentheses which
should not appear in return statement. This error was found by the
checkpatch.pl tool.

Signed-off-by: Michał Kwiatkowski <[email protected]>
---
drivers/staging/android/alarm-dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/alarm-dev.c b/drivers/staging/android/alarm-dev.c
index 647694f..96b2f53 100644
--- a/drivers/staging/android/alarm-dev.c
+++ b/drivers/staging/android/alarm-dev.c
@@ -68,8 +68,8 @@ static struct devalarm alarms[ANDROID_ALARM_TYPE_COUNT];
*/
static int is_wakeup(enum android_alarm_type type)
{
- return (type == ANDROID_ALARM_RTC_WAKEUP ||
- type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP);
+ return type == ANDROID_ALARM_RTC_WAKEUP ||
+ type == ANDROID_ALARM_ELAPSED_REALTIME_WAKEUP;
}


--
1.7.9.5

2014-01-14 21:43:07

by Levente Kurusa

Subject: Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

Hello,

2014/1/14 Micha? Kwiatkowski <[email protected]>:
> From: Michal Kwiatkowski <[email protected]>
>
> This is a patch to the alarm-dev.c file that removes parentheses which
> should not appear in return statement. This error was found by the
> checkpatch.pl tool.
>
> Signed-off-by: Micha? Kwiatkowski <[email protected]>
> --

This is like the third patch in this two week period that does the
exact same with more or less success, and I recall one getting applied
(I might be wrong). Anyway, this one finally looks good! :-)

--
Regards,
Levente Kurusa

2014-01-14 21:58:07

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: android: fix parentheses coding style issue in alarm-dev.c

On Tue, Jan 14, 2014 at 10:43:04PM +0100, Levente Kurusa wrote:
> Hello,
>
> 2014/1/14 Michał Kwiatkowski <[email protected]>:
> > From: Michal Kwiatkowski <[email protected]>
> >
> > This is a patch to the alarm-dev.c file that removes parentheses which
> > should not appear in return statement. This error was found by the
> > checkpatch.pl tool.
> >
> > Signed-off-by: Michał Kwiatkowski <[email protected]>
> > --
>
> This is like the third patch in this two week period that does the
> exact same with more or less success, and I recall one getting applied
> (I might be wrong). Anyway, this one finally looks good! :-)

You are right, it doesn't apply, Michal should have received my
rejection notice from my patch-bot already saying this.

thanks,

greg k-h