2014-01-28 01:32:26

by Markus Mayer

Subject: [PATCH] gpio: bcm281xx: Use "unsigned gpio" consistently throughout the code

This patch removes some inconsistencies caused by the use of "int gpio"
in some parts of the code and "unsigned gpio" in others.

Signed-off-by: Markus Mayer <[email protected]>
Reviewed-by: Tim Kryger <[email protected]>
---
drivers/gpio/gpio-bcm-kona.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c
index e5aa4d0..b4f20f7 100644
--- a/drivers/gpio/gpio-bcm-kona.c
+++ b/drivers/gpio/gpio-bcm-kona.c
@@ -323,7 +323,7 @@ static void bcm_kona_gpio_irq_ack(struct irq_data *d)
{
struct bcm_kona_gpio *kona_gpio;
void __iomem *reg_base;
- int gpio = d->hwirq;
+ unsigned gpio = d->hwirq;
int bank_id = GPIO_BANK(gpio);
int bit = GPIO_BIT(gpio);
u32 val;
@@ -344,7 +344,7 @@ static void bcm_kona_gpio_irq_mask(struct irq_data *d)
{
struct bcm_kona_gpio *kona_gpio;
void __iomem *reg_base;
- int gpio = d->hwirq;
+ unsigned gpio = d->hwirq;
int bank_id = GPIO_BANK(gpio);
int bit = GPIO_BIT(gpio);
u32 val;
@@ -365,7 +365,7 @@ static void bcm_kona_gpio_irq_unmask(struct irq_data *d)
{
struct bcm_kona_gpio *kona_gpio;
void __iomem *reg_base;
- int gpio = d->hwirq;
+ unsigned gpio = d->hwirq;
int bank_id = GPIO_BANK(gpio);
int bit = GPIO_BIT(gpio);
u32 val;
@@ -386,7 +386,7 @@ static int bcm_kona_gpio_irq_set_type(struct irq_data *d, unsigned int type)
{
struct bcm_kona_gpio *kona_gpio;
void __iomem *reg_base;
- int gpio = d->hwirq;
+ unsigned gpio = d->hwirq;
u32 lvl_type;
u32 val;
unsigned long flags;
--
1.7.9.5

2014-01-31 11:40:58

by Linus Walleij

Subject: Re: [PATCH] gpio: bcm281xx: Use "unsigned gpio" consistently throughout the code

On Tue, Jan 28, 2014 at 2:32 AM, Markus Mayer <[email protected]> wrote:

> This patch removes some inconsistencies caused by the use of "int gpio"
> in some parts of the code and "unsigned gpio" in others.
>
> Signed-off-by: Markus Mayer <[email protected]>
> Reviewed-by: Tim Kryger <[email protected]>

Patch applied, nice for static syntax checkers.

But the variable should probably be renamed from
"gpio" to "offset" since it's a local offset number on this
very GPIO block, not the global GPIO numberspace.

No big deal though.

Yours,
Linus Walleij