2014-02-02 11:11:12

by Ulrich Hahn

Subject: ..another device for the ftdi_sio driver, 3rd infusion

Signed-off-by: Ulrich Hahn <[email protected]>

diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio.c linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c
--- linux-3.13.1/drivers/usb/serial/ftdi_sio.c 2014-01-29 14:06:37.000000000 +0100
+++ linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c 2014-02-02 11:57:08.625914749 +0100
@@ -192,6 +192,8 @@
{ USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_IOBOARD_PID) },
{ USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_MINI_IOBOARD_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_SPROG_II) },
+ { USB_DEVICE(FTDI_VID, FTDI_TAGSYS_LP101_PID) },
+ { USB_DEVICE(FTDI_VID, FTDI_TAGSYS_P200X_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_LENZ_LIUSB_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_XF_632_PID) },
{ USB_DEVICE(FTDI_VID, FTDI_XF_634_PID) },
Only in linux-3.13.1+tagsys/drivers/usb/serial: ftdi_sio.c.orig
diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h
--- linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h 2014-01-29 14:06:37.000000000 +0100
+++ linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h 2014-02-02 11:57:08.629914782 +0100
@@ -363,6 +363,13 @@
/* Sprog II (Andrew Crosland's SprogII DCC interface) */
#define FTDI_SPROG_II 0xF0C8

+/*
+ * Tagsys RFID Readers
+ * survey (two of them) by Ulrich Hahn
+ */
+#define FTDI_TAGSYS_LP101_PID 0xF0E9 /* Tagsys L-P101 RFID*/
+#define FTDI_TAGSYS_P200X_PID 0xF0EE /* Tagsys Medio P200x RFID*/
+
/* an infrared receiver for user access control with IR tags */
#define FTDI_PIEGROUP_PID 0xF208 /* Product Id */

2014-02-02 13:15:27

by Johan Hovold

Subject: Re: ..another device for the ftdi_sio driver, 3rd infusion

On Sun, Feb 02, 2014 at 12:10:56PM +0100, Ulrich Hahn wrote:

Please use a more descriptive subject line (which will end up as the
commit log summary), e.g.

"[PATCH v3] USB: ftdi_sio: add Tagsys RFID Reader ids"

Note that the patch version should go in the [PATCH vX] (which will not
show up in the git log).

You should also consider adding a slightly more verbose message in the
body as well (e.g. mentioning which two devices you add support for).
Right now your commit log would be empty.

> Signed-off-by: Ulrich Hahn <[email protected]>
>
> diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio.c linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c
> --- linux-3.13.1/drivers/usb/serial/ftdi_sio.c 2014-01-29 14:06:37.000000000 +0100
> +++ linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio.c 2014-02-02 11:57:08.625914749 +0100
> @@ -192,6 +192,8 @@
> { USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_IOBOARD_PID) },
> { USB_DEVICE(INTERBIOMETRICS_VID, INTERBIOMETRICS_MINI_IOBOARD_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_SPROG_II) },
> + { USB_DEVICE(FTDI_VID, FTDI_TAGSYS_LP101_PID) },
> + { USB_DEVICE(FTDI_VID, FTDI_TAGSYS_P200X_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_LENZ_LIUSB_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_XF_632_PID) },
> { USB_DEVICE(FTDI_VID, FTDI_XF_634_PID) },
> Only in linux-3.13.1+tagsys/drivers/usb/serial: ftdi_sio.c.orig
> diff -ur linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h
> --- linux-3.13.1/drivers/usb/serial/ftdi_sio_ids.h 2014-01-29 14:06:37.000000000 +0100
> +++ linux-3.13.1+tagsys/drivers/usb/serial/ftdi_sio_ids.h 2014-02-02 11:57:08.629914782 +0100
> @@ -363,6 +363,13 @@
> /* Sprog II (Andrew Crosland's SprogII DCC interface) */
> #define FTDI_SPROG_II 0xF0C8
>
> +/*
> + * Tagsys RFID Readers
> + * survey (two of them) by Ulrich Hahn

No need to include the author in the comment. It will be apparent from
the git log.

> + */
> +#define FTDI_TAGSYS_LP101_PID 0xF0E9 /* Tagsys L-P101 RFID*/
> +#define FTDI_TAGSYS_P200X_PID 0xF0EE /* Tagsys Medio P200x RFID*/
> +
> /* an infrared receiver for user access control with IR tags */
> #define FTDI_PIEGROUP_PID 0xF208 /* Product Id */

Thanks,
Johan