2014-02-04 18:50:46

by Steven J. Magnani

Subject: [PATCH] qla2xxx: Re-sync module parameter descriptions with the code

Fix module parameter descriptions mentioning default values that no longer
match the code.

Signed-off-by: Steven J. Magnani <[email protected]>
---
diff -uprN linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
--- linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c 2014-02-02 18:42:13.000000000 -0600
+++ b/drivers/scsi/qla2xxx/qla_os.c 2014-02-04 12:41:45.133576764 -0600
@@ -120,15 +120,17 @@ MODULE_PARM_DESC(ql2xmaxqdepth,
int ql2xenabledif = 2;
module_param(ql2xenabledif, int, S_IRUGO);
MODULE_PARM_DESC(ql2xenabledif,
- " Enable T10-CRC-DIF "
- " Default is 0 - No DIF Support. 1 - Enable it"
- ", 2 - Enable DIF for all types, except Type 0.");
+ " Enable T10-CRC-DIF:\n"
+ " Default is 2.\n"
+ " 0 -- No DIF Support\n"
+ " 1 -- Enable DIF for all types\n"
+ " 2 -- Enable DIF for all types, except Type 0.\n");

int ql2xenablehba_err_chk = 2;
module_param(ql2xenablehba_err_chk, int, S_IRUGO|S_IWUSR);
MODULE_PARM_DESC(ql2xenablehba_err_chk,
" Enable T10-CRC-DIF Error isolation by HBA:\n"
- " Default is 1.\n"
+ " Default is 2.\n"
" 0 -- Error isolation disabled\n"
" 1 -- Error isolation enabled only for DIX Type 0\n"
" 2 -- Error isolation enabled for all Types\n");

2014-02-04 20:09:55

by Chad Dupuis

Subject: Re: [PATCH] qla2xxx: Re-sync module parameter descriptions with the code

On Tue, 4 Feb 2014, Steven J. Magnani wrote:

> Fix module parameter descriptions mentioning default values that no longer
> match the code.
>
> Signed-off-by: Steven J. Magnani <[email protected]>
> ---
> diff -uprN linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> --- linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c 2014-02-02 18:42:13.000000000 -0600
> +++ b/drivers/scsi/qla2xxx/qla_os.c 2014-02-04 12:41:45.133576764 -0600
> @@ -120,15 +120,17 @@ MODULE_PARM_DESC(ql2xmaxqdepth,
> int ql2xenabledif = 2;
> module_param(ql2xenabledif, int, S_IRUGO);
> MODULE_PARM_DESC(ql2xenabledif,
> - " Enable T10-CRC-DIF "
> - " Default is 0 - No DIF Support. 1 - Enable it"
> - ", 2 - Enable DIF for all types, except Type 0.");
> + " Enable T10-CRC-DIF:\n"
> + " Default is 2.\n"
> + " 0 -- No DIF Support\n"
> + " 1 -- Enable DIF for all types\n"
> + " 2 -- Enable DIF for all types, except Type 0.\n");
>
> int ql2xenablehba_err_chk = 2;
> module_param(ql2xenablehba_err_chk, int, S_IRUGO|S_IWUSR);
> MODULE_PARM_DESC(ql2xenablehba_err_chk,
> " Enable T10-CRC-DIF Error isolation by HBA:\n"
> - " Default is 1.\n"
> + " Default is 2.\n"
> " 0 -- Error isolation disabled\n"
> " 1 -- Error isolation enabled only for DIX Type 0\n"
> " 2 -- Error isolation enabled for all Types\n");
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

Looks good. Thanks.

Acked-by: Chad Dupuis <[email protected]>