2014-02-10 05:57:16

by Alexandre Courbot

[permalink] [raw]
Subject: [PATCH] drm/nouveau/fifo: allocate usermem as needed

Memory was always allocated for 4096 channels. Change this to allocate
what we actually need according to the number of channels we use.

Signed-off-by: Alexandre Courbot <[email protected]>
---
drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c b/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c
index 9a850fe19515..99c9deea248f 100644
--- a/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c
+++ b/drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c
@@ -852,8 +852,8 @@ nve0_fifo_ctor(struct nouveau_object *parent, struct nouveau_object *engine,
return ret;
}

- ret = nouveau_gpuobj_new(nv_object(priv), NULL, 4096 * 0x200, 0x1000,
- NVOBJ_FLAG_ZERO_ALLOC, &priv->user.mem);
+ ret = nouveau_gpuobj_new(nv_object(priv), NULL, impl->channels * 0x200,
+ 0x1000, NVOBJ_FLAG_ZERO_ALLOC, &priv->user.mem);
if (ret)
return ret;

--
1.8.5.4


2014-02-10 12:14:40

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] drm/nouveau/fifo: allocate usermem as needed

On Mon, Feb 10, 2014 at 02:57:01PM +0900, Alexandre Courbot wrote:
> Memory was always allocated for 4096 channels. Change this to allocate
> what we actually need according to the number of channels we use.
>
> Signed-off-by: Alexandre Courbot <[email protected]>
> ---
> drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me:

Reviewed-by: Thierry Reding <[email protected]>

Attachments:
(No filename) (454.00 B)
 (No filename) (836.00 B)
 Download all attachments

2014-02-14 02:02:23

by Ben Skeggs

[permalink] [raw]
Subject: Re: [Nouveau] [PATCH] drm/nouveau/fifo: allocate usermem as needed

On Mon, Feb 10, 2014 at 10:14 PM, Thierry Reding
<[email protected]> wrote:
> On Mon, Feb 10, 2014 at 02:57:01PM +0900, Alexandre Courbot wrote:
>> Memory was always allocated for 4096 channels. Change this to allocate
>> what we actually need according to the number of channels we use.
>>
>> Signed-off-by: Alexandre Courbot <[email protected]>
>> ---
>> drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Looks good to me:
>
> Reviewed-by: Thierry Reding <[email protected]>
Thanks guys!

>
> _______________________________________________
> Nouveau mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/nouveau
>