2014-02-11 04:51:27

by Laszlo Papp

[permalink] [raw]
Subject: [PATCH v2 1/2] mfd: fix a grammar issue in the Kconfig entries

"to support for" is incorrect English in here, hence the change to "to add
support".

Signed-off-by: Laszlo Papp <[email protected]>
---
drivers/mfd/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 49bb445..58f2fb5 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -100,7 +100,7 @@ config PMIC_DA903X
bool "Dialog Semiconductor DA9030/DA9034 PMIC Support"
depends on I2C=y
help
- Say yes here to support for Dialog Semiconductor DA9030 (a.k.a
+ Say yes here to add support for Dialog Semiconductor DA9030 (a.k.a
ARAVA) and DA9034 (a.k.a MICCO), these are Power Management IC
usually found on PXA processors-based platforms. This includes
the I2C driver and the core APIs _only_, you have to select
@@ -324,7 +324,7 @@ config MFD_MAX14577
select REGMAP_I2C
select IRQ_DOMAIN
help
- Say yes here to support for Maxim Semiconductor MAX14577.
+ Say yes here to add support for Maxim Semiconductor MAX14577.
This is a Micro-USB IC with Charger controls on chip.
This driver provides common support for accessing the device;
additional drivers must be enabled in order to use the functionality
@@ -337,7 +337,7 @@ config MFD_MAX77686
select REGMAP_I2C
select IRQ_DOMAIN
help
- Say yes here to support for Maxim Semiconductor MAX77686.
+ Say yes here to add support for Maxim Semiconductor MAX77686.
This is a Power Management IC with RTC on chip.
This driver provides common support for accessing the device;
additional drivers must be enabled in order to use the functionality
@@ -349,7 +349,7 @@ config MFD_MAX77693
select MFD_CORE
select REGMAP_I2C
help
- Say yes here to support for Maxim Semiconductor MAX77693.
+ Say yes here to add support for Maxim Semiconductor MAX77693.
This is a companion Power Management IC with Flash, Haptic, Charger,
and MUIC(Micro USB Interface Controller) controls on chip.
This driver provides common support for accessing the device;
@@ -363,7 +363,7 @@ config MFD_MAX8907
select REGMAP_I2C
select REGMAP_IRQ
help
- Say yes here to support for Maxim Semiconductor MAX8907. This is
+ Say yes here to add support for Maxim Semiconductor MAX8907. This is
a Power Management IC. This driver provides common support for
accessing the device; additional drivers must be enabled in order
to use the functionality of the device.
@@ -373,7 +373,7 @@ config MFD_MAX8925
depends on I2C=y
select MFD_CORE
help
- Say yes here to support for Maxim Semiconductor MAX8925. This is
+ Say yes here to add support for Maxim Semiconductor MAX8925. This is
a Power Management IC. This driver provides common support for
accessing the device, additional drivers must be enabled in order
to use the functionality of the device.
@@ -384,7 +384,7 @@ config MFD_MAX8997
select MFD_CORE
select IRQ_DOMAIN
help
- Say yes here to support for Maxim Semiconductor MAX8997/8966.
+ Say yes here to add support for Maxim Semiconductor MAX8997/8966.
This is a Power Management IC with RTC, Flash, Fuel Gauge, Haptic,
MUIC controls on chip.
This driver provides common support for accessing the device;
@@ -397,7 +397,7 @@ config MFD_MAX8998
select MFD_CORE
select IRQ_DOMAIN
help
- Say yes here to support for Maxim Semiconductor MAX8998 and
+ Say yes here to add support for Maxim Semiconductor MAX8998 and
National Semiconductor LP3974. This is a Power Management IC.
This driver provides common support for accessing the device,
additional drivers must be enabled in order to use the functionality
--
1.8.5.4


2014-02-12 09:23:51

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] mfd: fix a grammar issue in the Kconfig entries

> "to support for" is incorrect English in here, hence the change to "to add
> support".
>
> Signed-off-by: Laszlo Papp <[email protected]>
> ---
> drivers/mfd/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)

Surely you must have better things to do? ;)

Applied as trivial.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2014-02-12 10:04:23

by Laszlo Papp

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] mfd: fix a grammar issue in the Kconfig entries

On Wed, Feb 12, 2014 at 9:23 AM, Lee Jones <[email protected]> wrote:
>> "to support for" is incorrect English in here, hence the change to "to add
>> support".
>>
>> Signed-off-by: Laszlo Papp <[email protected]>
>> ---
>> drivers/mfd/Kconfig | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> Surely you must have better things to do? ;)

Sometimes it is good to see that one is useful, even if for small
things, after critics, etc. It also refreshes the brain at times not
to work only hard-core issues, causing better performance overall in
my experience. Also, consistency rocks whenever possible. :)

> Applied as trivial.

Thanks.