2014-02-25 15:52:34

by Kirill Tkhai

Subject: [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

In deadline class we do not have group scheduling.

So, let's remove unnecessary

X = X;

equations.

Signed-off-by: Kirill Tkhai <[email protected]>
CC: Juri Lelli <[email protected]>
CC: Peter Zijlstra <[email protected]>
CC: Ingo Molnar <[email protected]>
---
kernel/sched/deadline.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index ef96edc..2c28437 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
{
struct task_struct *p = dl_task_of(dl_se);
- dl_rq = &rq_of_dl_rq(dl_rq)->dl;

if (p->nr_cpus_allowed > 1)
dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
{
struct task_struct *p = dl_task_of(dl_se);
- dl_rq = &rq_of_dl_rq(dl_rq)->dl;

if (p->nr_cpus_allowed > 1)
dl_rq->dl_nr_migratory--;

2014-02-25 16:20:39

by Juri Lelli

Subject: Re: [PATCH] sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

On Tue, 25 Feb 2014 19:52:23 +0400
Kirill Tkhai <[email protected]> wrote:

>
> In deadline class we do not have group scheduling.
>
> So, let's remove unnecessary
>
> X = X;
>
> equations.
>

Thanks!

- Juri

> Signed-off-by: Kirill Tkhai <[email protected]>
> CC: Juri Lelli <[email protected]>
> CC: Peter Zijlstra <[email protected]>
> CC: Ingo Molnar <[email protected]>
> ---
> kernel/sched/deadline.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index ef96edc..2c28437 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
> static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
> {
> struct task_struct *p = dl_task_of(dl_se);
> - dl_rq = &rq_of_dl_rq(dl_rq)->dl;
>
> if (p->nr_cpus_allowed > 1)
> dl_rq->dl_nr_migratory++;
> @@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
> static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
> {
> struct task_struct *p = dl_task_of(dl_se);
> - dl_rq = &rq_of_dl_rq(dl_rq)->dl;
>
> if (p->nr_cpus_allowed > 1)
> dl_rq->dl_nr_migratory--;
>
>
>

2014-02-27 13:32:40

by tip-bot for Vasyl Gomonovych

Subject: [tip:sched/urgent] sched/deadline: Cleanup RT leftovers from {inc /dec}_dl_migration

Commit-ID: 3908ac13b550c93f97d8db136ff572be5495bc06
Gitweb: http://git.kernel.org/tip/3908ac13b550c93f97d8db136ff572be5495bc06
Author: Kirill Tkhai <[email protected]>
AuthorDate: Tue, 25 Feb 2014 19:52:23 +0400
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 27 Feb 2014 12:29:39 +0100

sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

In deadline class we do not have group scheduling.

So, let's remove unnecessary

X = X;

equations.

Signed-off-by: Kirill Tkhai <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
Cc: Juri Lelli <[email protected]>
Link: http://lkml.kernel.org/r/1393343543.4089.5.camel@tkhai
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/sched/deadline.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 15cbc17..aecf930 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
{
struct task_struct *p = dl_task_of(dl_se);
- dl_rq = &rq_of_dl_rq(dl_rq)->dl;

if (p->nr_cpus_allowed > 1)
dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
{
struct task_struct *p = dl_task_of(dl_se);
- dl_rq = &rq_of_dl_rq(dl_rq)->dl;

if (p->nr_cpus_allowed > 1)
dl_rq->dl_nr_migratory--;