2014-04-01 20:26:56

by David Cohen

[permalink] [raw]
Subject: [PATCH] regmap: rbtree: improve 64bits memory alignment

From: Jean-Christophe PINCE <[email protected]>

Change regcache_rbtree_node strcuture fields order to align the pointers on
64bits architectures.

Signed-off-by: Jean-Christophe PINCE <[email protected]>
Signed-off-by: David Cohen <[email protected]>
---
drivers/base/regmap/regcache-rbtree.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c
index 930cad4e5df8..6a7e4fa12854 100644
--- a/drivers/base/regmap/regcache-rbtree.c
+++ b/drivers/base/regmap/regcache-rbtree.c
@@ -23,16 +23,16 @@ static int regcache_rbtree_write(struct regmap *map, unsigned int reg,
static int regcache_rbtree_exit(struct regmap *map);

struct regcache_rbtree_node {
- /* the actual rbtree node holding this block */
- struct rb_node node;
- /* base register handled by this block */
- unsigned int base_reg;
/* block of adjacent registers */
void *block;
/* Which registers are present */
long *cache_present;
+ /* base register handled by this block */
+ unsigned int base_reg;
/* number of registers available in the block */
unsigned int blklen;
+ /* the actual rbtree node holding this block */
+ struct rb_node node;
} __attribute__ ((packed));

struct regcache_rbtree_ctx {
--
1.9.0


2014-04-02 13:10:44

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regmap: rbtree: improve 64bits memory alignment

On Tue, Apr 01, 2014 at 01:26:48PM -0700, David Cohen wrote:
> From: Jean-Christophe PINCE <[email protected]>
>
> Change regcache_rbtree_node strcuture fields order to align the pointers on
> 64bits architectures.

Applied, thanks. It seems like this is something there should be some
sort of tool for - it doesn't obviously fit into any of the existing
ones though.


Attachments:
(No filename) (384.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments