On 03/26/2014 08:57 AM, Limonciello, Mario wrote:
> This is a driver for the Alienware X51, X51 R2 and some future HW.
> - For the X51 / X51 R2 it allows control of the color and brightness
> of each zone via a sysfs interface for the color and a LED interface
> for the brightness
> - For the future HW it allows control of color and brightness as well
> as an HDMI mux that's included in the HW.
>
> Changes from v4 to v5:
> - Make zone control more like the thingm RGB LED in the kernel. Brightness
> control is independent of the RGB adjustment. RGB adjustment takes a 24-bit
> hexadecimal triplet.
> - Introduced a new WMAX method for platforms that use HDMI as well as a new
> lighting control interface. This removes the present necessity of having
> to do a DMI match on HDMI for now.
> - Dynamically create number of sysfs zone nodes based on DMI data. Present
> platforms have 3 nodes, but some future ones will have anywhere from 2
> to 32 nodes.
> - Make lighting control state and HDMI more readable and usable for
> interacting. Rather than having to know numbers, cat'ing the nodes will
> output the available options and the presently selected option (in a
> single line)
>
> Mario Limonciello (1):
> Add WMI driver for controlling AlienFX features on some Alienware
> products
>
> drivers/platform/x86/Kconfig | 12 +
> drivers/platform/x86/Makefile | 2 +
> drivers/platform/x86/alienware-wmi.c | 557 +++++++++++++++++++++++++++++++++++
> 3 files changed, 571 insertions(+)
> create mode 100644 drivers/platform/x86/alienware-wmi.c
>
Matthew,
Any feedback to apply on this?
Thanks,
On Tue, 2014-04-01 at 17:18 -0500, Mario Limonciello wrote:
> Matthew,
>
> Any feedback to apply on this?
I think this approach (not overloading the brightness attribute) is a
much better one, thanks. I have this queued, I'll send Linus a PR in a
couple of days once I've sorted out a couple of unrelated things.
--
Matthew Garrett <[email protected]>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay? ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?