2014-04-02 11:51:15

by Alexander Gordeev

Subject: [PATCH] GenWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block()

As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() or pci_enable_msi_exact()
and pci_enable_msix_range() or pci_enable_msix_exact()
interfaces.

Signed-off-by: Alexander Gordeev <[email protected]>
Cc: Frank Haverkamp <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
drivers/misc/genwqe/card_utils.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index 6b1a6ef..294f667 100644
--- a/drivers/misc/genwqe/card_utils.c
+++ b/drivers/misc/genwqe/card_utils.c
@@ -628,7 +628,7 @@ int genwqe_set_interrupt_capability(struct genwqe_dev *cd, int count)
int rc;
struct pci_dev *pci_dev = cd->pci_dev;

- rc = pci_enable_msi_block(pci_dev, count);
+ rc = pci_enable_msi_exact(pci_dev, count);
if (rc == 0)
cd->flags |= GENWQE_FLAG_MSI_ENABLED;
return rc;
--
1.7.7.6

2014-04-03 06:16:29

by haver

Subject: Re: [PATCH] GenWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block()

Hi Alexander,

Am Mittwoch, den 02.04.2014, 13:52 +0200 schrieb Alexander Gordeev:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <[email protected]>
> Cc: Frank Haverkamp <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/misc/genwqe/card_utils.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
> index 6b1a6ef..294f667 100644
> --- a/drivers/misc/genwqe/card_utils.c
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -628,7 +628,7 @@ int genwqe_set_interrupt_capability(struct genwqe_dev *cd, int count)
> int rc;
> struct pci_dev *pci_dev = cd->pci_dev;
>
> - rc = pci_enable_msi_block(pci_dev, count);
> + rc = pci_enable_msi_exact(pci_dev, count);
> if (rc == 0)
> cd->flags |= GENWQE_FLAG_MSI_ENABLED;
> return rc;

fine with me, if it works like it did before.

Acked-by: Frank Haverkamp <[email protected]>

2014-04-04 19:23:30

by Alexander Gordeev

Subject: Re: [PATCH] GenWQE: Use pci_enable_msi_exact() instead of pci_enable_msi_block()

On Wed, Apr 02, 2014 at 01:52:56PM +0200, Alexander Gordeev wrote:
> As result of deprecation of MSI-X/MSI enablement functions
> pci_enable_msix() and pci_enable_msi_block() all drivers
> using these two interfaces need to be updated to use the
> new pci_enable_msi_range() or pci_enable_msi_exact()
> and pci_enable_msix_range() or pci_enable_msix_exact()
> interfaces.
>
> Signed-off-by: Alexander Gordeev <[email protected]>
> Cc: Frank Haverkamp <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/misc/genwqe/card_utils.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

I forgot to CC linux-pci mailing list.
I will resend this patch with Frank's ACK after v3.15-rc1.

Thanks!

--
Regards,
Alexander Gordeev
[email protected]