2014-04-04 05:11:10

by Yuan Yao

Subject: [PATCH] dma: fix eDMA driver as a subsys_initcall

Because of some driver base on DMA, changed the initcall order as subsys_initcall.

Signed-off-by: Yuan Yao <[email protected]>
---
drivers/dma/fsl-edma.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
index 381e793..b396a7f 100644
--- a/drivers/dma/fsl-edma.c
+++ b/drivers/dma/fsl-edma.c
@@ -968,7 +968,17 @@ static struct platform_driver fsl_edma_driver = {
.remove = fsl_edma_remove,
};

-module_platform_driver(fsl_edma_driver);
+static int __init fsl_edma_init(void)
+{
+ return platform_driver_register(&fsl_edma_driver);
+}
+subsys_initcall(fsl_edma_init);
+
+static void __exit fsl_edma_exit(void)
+{
+ platform_driver_unregister(&fsl_edma_driver);
+}
+module_exit(fsl_edma_exit);

MODULE_ALIAS("platform:fsl-edma");
MODULE_DESCRIPTION("Freescale eDMA engine driver");
--
1.8.4

2014-04-16 06:44:25

by Vinod Koul

Subject: Re: [PATCH] dma: fix eDMA driver as a subsys_initcall

On Fri, Apr 04, 2014 at 12:27:55PM +0800, Yuan Yao wrote:
> Because of some driver base on DMA, changed the initcall order as subsys_initcall.

Changelog could have mentioned "which" driver and elobrated on it
>
> Signed-off-by: Yuan Yao <[email protected]>

Applied, nevertheless

--
~Vinod
> ---
> drivers/dma/fsl-edma.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
> index 381e793..b396a7f 100644
> --- a/drivers/dma/fsl-edma.c
> +++ b/drivers/dma/fsl-edma.c
> @@ -968,7 +968,17 @@ static struct platform_driver fsl_edma_driver = {
> .remove = fsl_edma_remove,
> };
>
> -module_platform_driver(fsl_edma_driver);
> +static int __init fsl_edma_init(void)
> +{
> + return platform_driver_register(&fsl_edma_driver);
> +}
> +subsys_initcall(fsl_edma_init);
> +
> +static void __exit fsl_edma_exit(void)
> +{
> + platform_driver_unregister(&fsl_edma_driver);
> +}
> +module_exit(fsl_edma_exit);
>
> MODULE_ALIAS("platform:fsl-edma");
> MODULE_DESCRIPTION("Freescale eDMA engine driver");
> --
> 1.8.4
>
>

--