2014-04-07 02:51:59

by Daeseok Youn

Subject: [PATCH] [SCSI] FlashPoint: Fix non-ANSI function declaration

sparse says:
non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/scsi/FlashPoint.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index 5c74e4c..867b864 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card,
*
*---------------------------------------------------------------------*/

-static void FPT_SccbMgrTableInitAll()
+static void FPT_SccbMgrTableInitAll(void)
{
unsigned char thisCard;

--
1.7.4.4

2014-04-07 03:06:17

by Khalid Aziz

Subject: Re: [PATCH] [SCSI] FlashPoint: Fix non-ANSI function declaration

On Mon, 2014-04-07 at 11:51 +0900, Daeseok Youn wrote:
> sparse says:
> non-ANSI function declaration of function 'FPT_SccbMgrTableInitAll'
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---
> drivers/scsi/FlashPoint.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 5c74e4c..867b864 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -2136,7 +2136,7 @@ static unsigned char FPT_SccbMgr_bad_isr(u32 p_port, unsigned char p_card,
> *
> *---------------------------------------------------------------------*/
>
> -static void FPT_SccbMgrTableInitAll()
> +static void FPT_SccbMgrTableInitAll(void)
> {
> unsigned char thisCard;
>

Acked-by: Khalid Aziz <[email protected]>