2014-04-08 18:02:12

by Paul McQuade

[permalink] [raw]
Subject: [PATCH 3/3] Staging:android:uapi:binder.h __packed

WARNING: __packed is preferred over __attribute__((packed))

Signed-off-by: Paul McQuade <[email protected]>
---
drivers/staging/android/uapi/binder.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/uapi/binder.h b/drivers/staging/android/uapi/binder.h
index 904adb7..dba4cef 100644
--- a/drivers/staging/android/uapi/binder.h
+++ b/drivers/staging/android/uapi/binder.h
@@ -169,7 +169,7 @@ struct binder_ptr_cookie {
struct binder_handle_cookie {
__u32 handle;
binder_uintptr_t cookie;
-} __attribute__((packed));
+} __packed;

struct binder_pri_desc {
__s32 priority;
--
1.8.3.2


2014-04-17 03:15:18

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 3/3] Staging:android:uapi:binder.h __packed

On Tue, Apr 08, 2014 at 07:02:04PM +0100, Paul McQuade wrote:
> WARNING: __packed is preferred over __attribute__((packed))
>
> Signed-off-by: Paul McQuade <[email protected]>
> ---
> drivers/staging/android/uapi/binder.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Not on uapi .h files, sorry :(