2014-04-09 07:16:07

by Masahiro Yamada

Subject: [PATCH] x86: suppress "Nothing to be done for ..." messages

When we compiled again, arch/x86/syscalls/Makefile and
arch/x86/tools/Makefile emitted "Nothing to be done for ..." messages.

Here is the command log:

$ make defconfig
[ snip ]
$ make
[ snip ]
$ make
make[1]: Nothing to be done for `all'. <-----
make[1]: Nothing to be done for `relocs'. <-----
CHK include/config/kernel.release
CHK include/generated/uapi/linux/version.h

Signed-off-by: Masahiro Yamada <[email protected]>
---
arch/x86/syscalls/Makefile | 1 +
arch/x86/tools/Makefile | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
index f325af2..b6c923a 100644
--- a/arch/x86/syscalls/Makefile
+++ b/arch/x86/syscalls/Makefile
@@ -56,3 +56,4 @@ targets += $(uapisyshdr-y) $(syshdr-y)

all: $(addprefix $(uapi)/,$(uapisyshdr-y))
all: $(addprefix $(out)/,$(syshdr-y))
+ @:
diff --git a/arch/x86/tools/Makefile b/arch/x86/tools/Makefile
index e812034..95e3ed7 100644
--- a/arch/x86/tools/Makefile
+++ b/arch/x86/tools/Makefile
@@ -41,3 +41,4 @@ HOST_EXTRACFLAGS += -I$(srctree)/tools/include
hostprogs-y += relocs
relocs-objs := relocs_32.o relocs_64.o relocs_common.o
relocs: $(obj)/relocs
+ @:
--
1.8.3.2

2014-04-09 14:10:24

by Peter Foley

Subject: Re: [PATCH] x86: suppress "Nothing to be done for ..." messages

On Wed, Apr 9, 2014 at 3:15 AM, Masahiro Yamada
<[email protected]> wrote:
> When we compiled again, arch/x86/syscalls/Makefile and
> arch/x86/tools/Makefile emitted "Nothing to be done for ..." messages.
>
> Here is the command log:
>
> $ make defconfig
> [ snip ]
> $ make
> [ snip ]
> $ make
> make[1]: Nothing to be done for `all'. <-----
> make[1]: Nothing to be done for `relocs'. <-----
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
> arch/x86/syscalls/Makefile | 1 +
> arch/x86/tools/Makefile | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
> index f325af2..b6c923a 100644
> --- a/arch/x86/syscalls/Makefile
> +++ b/arch/x86/syscalls/Makefile
> @@ -56,3 +56,4 @@ targets += $(uapisyshdr-y) $(syshdr-y)
>
> all: $(addprefix $(uapi)/,$(uapisyshdr-y))
> all: $(addprefix $(out)/,$(syshdr-y))
> + @:
> diff --git a/arch/x86/tools/Makefile b/arch/x86/tools/Makefile
> index e812034..95e3ed7 100644
> --- a/arch/x86/tools/Makefile
> +++ b/arch/x86/tools/Makefile
> @@ -41,3 +41,4 @@ HOST_EXTRACFLAGS += -I$(srctree)/tools/include
> hostprogs-y += relocs
> relocs-objs := relocs_32.o relocs_64.o relocs_common.o
> relocs: $(obj)/relocs
> + @:
> --
> 1.8.3.2
>
> --

Acked-by: Peter Foley <[email protected]>

I've an identical patch lying around that I haven't gotten around to
submitting yet.

2014-04-09 14:15:02

by Michal Marek

Subject: Re: [PATCH] x86: suppress "Nothing to be done for ..." messages

ccing x86 maintainers

On 2014-04-09 09:15, Masahiro Yamada wrote:
> When we compiled again, arch/x86/syscalls/Makefile and
> arch/x86/tools/Makefile emitted "Nothing to be done for ..." messages.
>
> Here is the command log:
>
> $ make defconfig
> [ snip ]
> $ make
> [ snip ]
> $ make
> make[1]: Nothing to be done for `all'. <-----
> make[1]: Nothing to be done for `relocs'. <-----
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
> arch/x86/syscalls/Makefile | 1 +
> arch/x86/tools/Makefile | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
> index f325af2..b6c923a 100644
> --- a/arch/x86/syscalls/Makefile
> +++ b/arch/x86/syscalls/Makefile
> @@ -56,3 +56,4 @@ targets += $(uapisyshdr-y) $(syshdr-y)
>
> all: $(addprefix $(uapi)/,$(uapisyshdr-y))
> all: $(addprefix $(out)/,$(syshdr-y))
> + @:

The "all" target should also be added to the PHONY variable.


> diff --git a/arch/x86/tools/Makefile b/arch/x86/tools/Makefile
> index e812034..95e3ed7 100644
> --- a/arch/x86/tools/Makefile
> +++ b/arch/x86/tools/Makefile
> @@ -41,3 +41,4 @@ HOST_EXTRACFLAGS += -I$(srctree)/tools/include
> hostprogs-y += relocs
> relocs-objs := relocs_32.o relocs_64.o relocs_common.o
> relocs: $(obj)/relocs
> + @:
>

You can add Acked-by: Michal Marek <[email protected]> if you want.

Michal

2014-04-09 14:25:38

by Peter Foley

Subject: Re: [PATCH] x86: suppress "Nothing to be done for ..." messages

On Wed, Apr 9, 2014 at 10:14 AM, Michal Marek <[email protected]> wrote:
> ccing x86 maintainers
>
> On 2014-04-09 09:15, Masahiro Yamada wrote:
>> When we compiled again, arch/x86/syscalls/Makefile and
>> arch/x86/tools/Makefile emitted "Nothing to be done for ..." messages.
>>
>> Here is the command log:
>>
>> $ make defconfig
>> [ snip ]
>> $ make
>> [ snip ]
>> $ make
>> make[1]: Nothing to be done for `all'. <-----
>> make[1]: Nothing to be done for `relocs'. <-----
>> CHK include/config/kernel.release
>> CHK include/generated/uapi/linux/version.h
>>
>> Signed-off-by: Masahiro Yamada <[email protected]>
>> ---
>> arch/x86/syscalls/Makefile | 1 +
>> arch/x86/tools/Makefile | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/syscalls/Makefile b/arch/x86/syscalls/Makefile
>> index f325af2..b6c923a 100644
>> --- a/arch/x86/syscalls/Makefile
>> +++ b/arch/x86/syscalls/Makefile
>> @@ -56,3 +56,4 @@ targets += $(uapisyshdr-y) $(syshdr-y)
>>
>> all: $(addprefix $(uapi)/,$(uapisyshdr-y))
>> all: $(addprefix $(out)/,$(syshdr-y))
>> + @:
>
> The "all" target should also be added to the PHONY variable.

relocs should be PHONY too.