2014-04-09 07:44:16

by Christoph Jaeger

Subject: [PATCH] sound: dmasound: use module_platform_driver_probe()

Eliminate boilerplate code by using module_platform_driver_probe().

Signed-off-by: Christoph Jaeger <[email protected]>
---
sound/oss/dmasound/dmasound_paula.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/sound/oss/dmasound/dmasound_paula.c b/sound/oss/dmasound/dmasound_paula.c
index 87910e9..c2d45a5 100644
--- a/sound/oss/dmasound/dmasound_paula.c
+++ b/sound/oss/dmasound/dmasound_paula.c
@@ -733,19 +733,7 @@ static struct platform_driver amiga_audio_driver = {
},
};

-static int __init amiga_audio_init(void)
-{
- return platform_driver_probe(&amiga_audio_driver, amiga_audio_probe);
-}
-
-module_init(amiga_audio_init);
-
-static void __exit amiga_audio_exit(void)
-{
- platform_driver_unregister(&amiga_audio_driver);
-}
-
-module_exit(amiga_audio_exit);
+module_platform_driver_probe(amiga_audio_driver, amiga_audio_probe);

MODULE_LICENSE("GPL");
MODULE_ALIAS("platform:amiga-audio");
--
1.9.0

2014-04-09 08:05:28

by Takashi Iwai

Subject: Re: [PATCH] sound: dmasound: use module_platform_driver_probe()

At Wed, 9 Apr 2014 09:43:53 +0200,
Christoph Jaeger wrote:
>
> Eliminate boilerplate code by using module_platform_driver_probe().
>
> Signed-off-by: Christoph Jaeger <[email protected]>

Thanks, applied.


Takashi

> ---
> sound/oss/dmasound/dmasound_paula.c | 14 +-------------
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/sound/oss/dmasound/dmasound_paula.c b/sound/oss/dmasound/dmasound_paula.c
> index 87910e9..c2d45a5 100644
> --- a/sound/oss/dmasound/dmasound_paula.c
> +++ b/sound/oss/dmasound/dmasound_paula.c
> @@ -733,19 +733,7 @@ static struct platform_driver amiga_audio_driver = {
> },
> };
>
> -static int __init amiga_audio_init(void)
> -{
> - return platform_driver_probe(&amiga_audio_driver, amiga_audio_probe);
> -}
> -
> -module_init(amiga_audio_init);
> -
> -static void __exit amiga_audio_exit(void)
> -{
> - platform_driver_unregister(&amiga_audio_driver);
> -}
> -
> -module_exit(amiga_audio_exit);
> +module_platform_driver_probe(amiga_audio_driver, amiga_audio_probe);
>
> MODULE_LICENSE("GPL");
> MODULE_ALIAS("platform:amiga-audio");
> --
> 1.9.0
>