2014-04-11 09:59:04

by Gu Zheng

[permalink] [raw]
Subject: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge

Gu Zheng (7):
f2fs: put the bio when issue_flush completed
f2fs: remove the unuseful "issue_tail" list
f2fs: use __GFP_ZERO to avoid appending set-NULL
f2fs: enable flush_merge only in f2fs is not read-only
f2fs: add the flush_merge handle in the remount flow
f2fs: introduce struct flush_cmd_control to wrap the flush_merge
fields
f2fs: introduce help function {create,destroy}_flush_cmd_control

fs/f2fs/f2fs.h | 17 ++++++---
fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
fs/f2fs/super.c | 32 ++++++++++++++--
3 files changed, 107 insertions(+), 44 deletions(-)

--
1.7.7


2014-04-14 01:27:43

by Gu Zheng

[permalink] [raw]
Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge

Hi All,
There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list",
and the whole patchset needs to be reworked. So please ignore this one.
Sorry for the noise.

Regards,
Gu
On 04/11/2014 05:49 PM, Gu Zheng wrote:

> Gu Zheng (7):
> f2fs: put the bio when issue_flush completed
> f2fs: remove the unuseful "issue_tail" list
> f2fs: use __GFP_ZERO to avoid appending set-NULL
> f2fs: enable flush_merge only in f2fs is not read-only
> f2fs: add the flush_merge handle in the remount flow
> f2fs: introduce struct flush_cmd_control to wrap the flush_merge
> fields
> f2fs: introduce help function {create,destroy}_flush_cmd_control
>
> fs/f2fs/f2fs.h | 17 ++++++---
> fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
> fs/f2fs/super.c | 32 ++++++++++++++--
> 3 files changed, 107 insertions(+), 44 deletions(-)
>

2014-04-14 01:46:22

by Jaegeuk Kim

[permalink] [raw]
Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge

Hi Gu,

I just started to review the patches and merge them individually though.
Since I've been internally doing in my local tree, so that should be no
problem. I'll roll back to the latest point.
Anyway, thank you for your work. :)

2014-04-14 (월), 09:18 +0800, Gu Zheng:
> Hi All,
> There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list",
> and the whole patchset needs to be reworked. So please ignore this one.
> Sorry for the noise.
>
> Regards,
> Gu
> On 04/11/2014 05:49 PM, Gu Zheng wrote:
>
> > Gu Zheng (7):
> > f2fs: put the bio when issue_flush completed
> > f2fs: remove the unuseful "issue_tail" list
> > f2fs: use __GFP_ZERO to avoid appending set-NULL
> > f2fs: enable flush_merge only in f2fs is not read-only
> > f2fs: add the flush_merge handle in the remount flow
> > f2fs: introduce struct flush_cmd_control to wrap the flush_merge
> > fields
> > f2fs: introduce help function {create,destroy}_flush_cmd_control
> >
> > fs/f2fs/f2fs.h | 17 ++++++---
> > fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
> > fs/f2fs/super.c | 32 ++++++++++++++--
> > 3 files changed, 107 insertions(+), 44 deletions(-)
> >
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Jaegeuk Kim
Samsung

2014-04-14 01:58:01

by Gu Zheng

[permalink] [raw]
Subject: Re: [PATCH 0/7] f2fs: some fix and cleanup about flush_merge

On 04/14/2014 09:44 AM, Jaegeuk Kim wrote:

> Hi Gu,
>
> I just started to review the patches and merge them individually though.
> Since I've been internally doing in my local tree, so that should be no
> problem. I'll roll back to the latest point.

OK, and please pay some attention to the flush cmds merging operation when doing
tests, it seems that some of the outstanding flush cmds(in the issue_list) will
be ignored when new cmd added.
I'll review and test it more.

> Anyway, thank you for your work. :)


Regards,
Gu

>
> 2014-04-14 (월), 09:18 +0800, Gu Zheng:
>> Hi All,
>> There seems to be a mistake in "[PATCH 2/7]f2fs: remove the unuseful "issue_tail" list",
>> and the whole patchset needs to be reworked. So please ignore this one.
>> Sorry for the noise.
>>
>> Regards,
>> Gu
>> On 04/11/2014 05:49 PM, Gu Zheng wrote:
>>
>>> Gu Zheng (7):
>>> f2fs: put the bio when issue_flush completed
>>> f2fs: remove the unuseful "issue_tail" list
>>> f2fs: use __GFP_ZERO to avoid appending set-NULL
>>> f2fs: enable flush_merge only in f2fs is not read-only
>>> f2fs: add the flush_merge handle in the remount flow
>>> f2fs: introduce struct flush_cmd_control to wrap the flush_merge
>>> fields
>>> f2fs: introduce help function {create,destroy}_flush_cmd_control
>>>
>>> fs/f2fs/f2fs.h | 17 ++++++---
>>> fs/f2fs/segment.c | 102 +++++++++++++++++++++++++++++++++++-----------------
>>> fs/f2fs/super.c | 32 ++++++++++++++--
>>> 3 files changed, 107 insertions(+), 44 deletions(-)
>>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>