2014-04-15 01:54:14

by Li, ZhenHua

Subject: [PATCH 1/1] driver/net: cosa driver uses udelay incorrectly

From: "Li, Zhen-Hua" <[email protected]>

In cosa driver, udelay with more than 20000 may cause __bad_udelay.
Use msleep for instead.

Signed-off-by: Li, Zhen-Hua <[email protected]>
---
drivers/net/wan/cosa.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index 84734a8..83c39e2 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -1521,11 +1521,7 @@ static int cosa_reset_and_read_id(struct cosa_data *cosa, char *idstring)
cosa_putstatus(cosa, 0);
cosa_getdata8(cosa);
cosa_putstatus(cosa, SR_RST);
-#ifdef MODULE
msleep(500);
-#else
- udelay(5*100000);
-#endif
/* Disable all IRQs from the card */
cosa_putstatus(cosa, 0);

--
1.7.10.4

2014-04-15 04:09:28

by David Miller

Subject: Re: [PATCH 1/1] driver/net: cosa driver uses udelay incorrectly

From: "Li, Zhen-Hua" <[email protected]>
Date: Tue, 15 Apr 2014 09:53:11 +0800

> From: "Li, Zhen-Hua" <[email protected]>
>
> In cosa driver, udelay with more than 20000 may cause __bad_udelay.
> Use msleep for instead.
>
> Signed-off-by: Li, Zhen-Hua <[email protected]>

Applied, thank you.