2014-04-15 15:05:35

by Mathieu Desnoyers

Subject: [PATCH] Fix: tracing: use 'E' instead of 'X' for unsigned module tain flag

In the following commit:

commit 57673c2b0baa900dddae3b9eb3d7748ebf550eb3
Author: Rusty Russell <[email protected]>
Date: Mon Mar 31 14:39:57 2014 +1030

Use 'E' instead of 'X' for unsigned module taint flag.

One site has been forgotten in trace events module.h.

Signed-off-by: Mathieu Desnoyers <[email protected]>
CC: Steven Rostedt <[email protected]>
CC: Rusty Russell <[email protected]>
---
include/trace/events/module.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/module.h b/include/trace/events/module.h
index 11fd51b..ed0b2c5 100644
--- a/include/trace/events/module.h
+++ b/include/trace/events/module.h
@@ -25,7 +25,7 @@ struct module;
{ (1UL << TAINT_OOT_MODULE), "O" }, \
{ (1UL << TAINT_FORCED_MODULE), "F" }, \
{ (1UL << TAINT_CRAP), "C" }, \
- { (1UL << TAINT_UNSIGNED_MODULE), "X" })
+ { (1UL << TAINT_UNSIGNED_MODULE), "E" })

TRACE_EVENT(module_load,

--
1.7.10.4

2014-04-23 05:41:31

by Rusty Russell

Subject: Re: [PATCH] Fix: tracing: use 'E' instead of 'X' for unsigned module tain flag

Mathieu Desnoyers <[email protected]> writes:
> In the following commit:
>
> commit 57673c2b0baa900dddae3b9eb3d7748ebf550eb3
> Author: Rusty Russell <[email protected]>
> Date: Mon Mar 31 14:39:57 2014 +1030
>
> Use 'E' instead of 'X' for unsigned module taint flag.
>
> One site has been forgotten in trace events module.h.

Hmm, these are crying out to be unified.

Applied,
Rusty.