2014-04-15 17:51:33

by Peter Foley

Subject: [PATCH] ata: fix kconfig selection warning

When building with COMPILE_TEST, AHCI_XGENE is enabled even though
PHY_XGENE (which it selects) requires OF to be enabled.
Fix this by adding a dependency on OF to AHCI_XGENE.

warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))

Signed-off-by: Peter Foley <[email protected]>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 20e03a7..071f399 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -134,7 +134,7 @@ config AHCI_SUNXI

config AHCI_XGENE
tristate "APM X-Gene 6.0Gbps AHCI SATA host controller support"
- depends on ARM64 || COMPILE_TEST
+ depends on OF && (ARM64 || COMPILE_TEST)
select PHY_XGENE
help
This option enables support for APM X-Gene SoC SATA host controller.
--
1.9.2

2014-04-15 18:17:23

by Tejun Heo

Subject: Re: [PATCH] ata: fix kconfig selection warning

Hello,

On Tue, Apr 15, 2014 at 01:50:55PM -0400, Peter Foley wrote:
> When building with COMPILE_TEST, AHCI_XGENE is enabled even though
> PHY_XGENE (which it selects) requires OF to be enabled.
> Fix this by adding a dependency on OF to AHCI_XGENE.
>
> warning: (AHCI_XGENE) selects PHY_XGENE which has unmet direct
> dependencies (HAS_IOMEM && OF && (ARM64 || COMPILE_TEST))
>
> Signed-off-by: Peter Foley <[email protected]>

Already fixed in libata/for-3.15-fixes. Will push out in several
days.

Thanks.

--
tejun