2014-04-16 14:18:55

by Tim Gardner

Subject: [PATCH v2 linux-next] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

BugLink: http://bugs.launchpad.net/bugs/1305480

The kerneloops-daemon scans dmesg for common crash signatures, among
which is 'BUG:'. The message emitted by the PCM library is really a
warning, so the most expedient thing to do seems to be to change the
string.

Cc: Jaroslav Kysela <[email protected]>
Cc: Takashi Iwai <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Lars-Peter Clausen <[email protected]>
Cc: JongHo Kim <[email protected]>
Signed-off-by: Tim Gardner <[email protected]>
---

v2: Changed string preface from "OVER RUN" to "XRUN". As Takashi pointed out,
'Use a term "XRUN", as it's not always an overrun.'

sound/core/pcm_lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index ce83def..9acc77e 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
snd_pcm_debug_name(substream, name, sizeof(name));
xrun_log_show(substream);
pcm_err(substream->pcm,
- "BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
+ "XRUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
name, pos, runtime->buffer_size,
runtime->period_size);
}
--
1.9.1

2014-04-16 14:21:30

by Takashi Iwai

Subject: Re: [PATCH v2 linux-next] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

At Wed, 16 Apr 2014 08:18:35 -0600,
Tim Gardner wrote:
>
> BugLink: http://bugs.launchpad.net/bugs/1305480
>
> The kerneloops-daemon scans dmesg for common crash signatures, among
> which is 'BUG:'. The message emitted by the PCM library is really a
> warning, so the most expedient thing to do seems to be to change the
> string.
>
> Cc: Jaroslav Kysela <[email protected]>
> Cc: Takashi Iwai <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Lars-Peter Clausen <[email protected]>
> Cc: JongHo Kim <[email protected]>
> Signed-off-by: Tim Gardner <[email protected]>

Thanks, applied.


Takashi

> ---
>
> v2: Changed string preface from "OVER RUN" to "XRUN". As Takashi pointed out,
> 'Use a term "XRUN", as it's not always an overrun.'
>
> sound/core/pcm_lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index ce83def..9acc77e 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
> snd_pcm_debug_name(substream, name, sizeof(name));
> xrun_log_show(substream);
> pcm_err(substream->pcm,
> - "BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
> + "XRUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
> name, pos, runtime->buffer_size,
> runtime->period_size);
> }
> --
> 1.9.1
>