2014-04-22 07:11:47

by Peter Ujfalusi

Subject: [PATCH] ARM: Wire up the renameat2() syscall

The new renameat2() system call was only wired up for ARM causing:
CALL /home/ujfalusi/work/kernel/kernel.org-next-linux-next/scripts/checksyscalls.sh
<stdin>:1232:2: warning: #warning syscall renameat2 not implemented [-Wcpp]

Signed-off-by: Peter Ujfalusi <[email protected]>
---
Hi,

I have noticed this with linux-next.

Regards,
Peter

arch/arm/include/uapi/asm/unistd.h | 1 +
arch/arm/kernel/calls.S | 1 +
2 files changed, 2 insertions(+)

diff --git a/arch/arm/include/uapi/asm/unistd.h b/arch/arm/include/uapi/asm/unistd.h
index fb5584d0cc05..ba94446c72d9 100644
--- a/arch/arm/include/uapi/asm/unistd.h
+++ b/arch/arm/include/uapi/asm/unistd.h
@@ -408,6 +408,7 @@
#define __NR_finit_module (__NR_SYSCALL_BASE+379)
#define __NR_sched_setattr (__NR_SYSCALL_BASE+380)
#define __NR_sched_getattr (__NR_SYSCALL_BASE+381)
+#define __NR_renameat2 (__NR_SYSCALL_BASE+382)

/*
* This may need to be greater than __NR_last_syscall+1 in order to
diff --git a/arch/arm/kernel/calls.S b/arch/arm/kernel/calls.S
index 166e945de832..8f51bdcdacbb 100644
--- a/arch/arm/kernel/calls.S
+++ b/arch/arm/kernel/calls.S
@@ -391,6 +391,7 @@
CALL(sys_finit_module)
/* 380 */ CALL(sys_sched_setattr)
CALL(sys_sched_getattr)
+ CALL(sys_renameat2)
#ifndef syscalls_counted
.equ syscalls_padding, ((NR_syscalls + 3) & ~3) - NR_syscalls
#define syscalls_counted
--
1.9.2

2014-04-23 14:04:35

by Peter Ujfalusi

Subject: Re: [PATCH] ARM: Wire up the renameat2() syscall

On 04/22/2014 10:05 AM, Peter Ujfalusi wrote:
> The new renameat2() system call was only wired up for ARM causing:

obviously I mean that "system call was _not_ wired up for ARM causing"

I can send the patch again with a fixed up commit message...

> CALL /home/ujfalusi/work/kernel/kernel.org-next-linux-next/scripts/checksyscalls.sh
> <stdin>:1232:2: warning: #warning syscall renameat2 not implemented [-Wcpp]
>
> Signed-off-by: Peter Ujfalusi <[email protected]>
> ---
> Hi,
>
> I have noticed this with linux-next.
>
> Regards,
> Peter
>
> arch/arm/include/uapi/asm/unistd.h | 1 +
> arch/arm/kernel/calls.S | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/uapi/asm/unistd.h b/arch/arm/include/uapi/asm/unistd.h
> index fb5584d0cc05..ba94446c72d9 100644
> --- a/arch/arm/include/uapi/asm/unistd.h
> +++ b/arch/arm/include/uapi/asm/unistd.h
> @@ -408,6 +408,7 @@
> #define __NR_finit_module (__NR_SYSCALL_BASE+379)
> #define __NR_sched_setattr (__NR_SYSCALL_BASE+380)
> #define __NR_sched_getattr (__NR_SYSCALL_BASE+381)
> +#define __NR_renameat2 (__NR_SYSCALL_BASE+382)
>
> /*
> * This may need to be greater than __NR_last_syscall+1 in order to
> diff --git a/arch/arm/kernel/calls.S b/arch/arm/kernel/calls.S
> index 166e945de832..8f51bdcdacbb 100644
> --- a/arch/arm/kernel/calls.S
> +++ b/arch/arm/kernel/calls.S
> @@ -391,6 +391,7 @@
> CALL(sys_finit_module)
> /* 380 */ CALL(sys_sched_setattr)
> CALL(sys_sched_getattr)
> + CALL(sys_renameat2)
> #ifndef syscalls_counted
> .equ syscalls_padding, ((NR_syscalls + 3) & ~3) - NR_syscalls
> #define syscalls_counted
>


--
P?ter