2014-04-25 00:49:11

by Xiao, Jin

Subject: [PATCH] inetpeer_gc_worker: trivial cleanup

Do not initialize list twice.
list_replace_init() already takes care of initializing list.
We don't need to initialize it with LIST_HEAD() beforehand.

Signed-off-by: xiao jin <[email protected]>
Reviewed-by: David Cohen <[email protected]>
---
net/ipv4/inetpeer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/inetpeer.c b/net/ipv4/inetpeer.c
index 48f4244..c98cf14 100644
--- a/net/ipv4/inetpeer.c
+++ b/net/ipv4/inetpeer.c
@@ -120,7 +120,7 @@ int inet_peer_maxttl __read_mostly = 10 * 60 * HZ; /* usual time to live: 10 min
static void inetpeer_gc_worker(struct work_struct *work)
{
struct inet_peer *p, *n, *c;
- LIST_HEAD(list);
+ struct list_head list;

spin_lock_bh(&gc_lock);
list_replace_init(&gc_list, &list);
--
1.7.9.5

2014-04-26 16:53:07

by David Miller

Subject: Re: [PATCH] inetpeer_gc_worker: trivial cleanup

From: xiao jin <[email protected]>
Date: Fri, 25 Apr 2014 08:53:29 +0800

> Do not initialize list twice.
> list_replace_init() already takes care of initializing list.
> We don't need to initialize it with LIST_HEAD() beforehand.
>
> Signed-off-by: xiao jin <[email protected]>
> Reviewed-by: David Cohen <[email protected]>

Also applied, thank you.