2014-04-25 19:53:23

by Jon Ringle

Subject: [PATCH 1/2] serial: sc16is7xx: depend on I2C

From: Jon Ringle <[email protected]>

Signed-off-by: Jon Ringle <[email protected]>
---
drivers/tty/serial/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index c3e2b32..64c5659 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE

config SERIAL_SC16IS7XX
tristate "SC16IS7xx serial support"
+ depends on I2C
select SERIAL_CORE
select REGMAP_I2C if I2C
help
--
1.8.5.4

2014-04-25 19:53:25

by Jon Ringle

Subject: [PATCH 2/2] serial: sc16is7xx: fix implicit decl of func copy_{to,from}_user

From: Jon Ringle <[email protected]>

Fix by including linux/uaccess.h:

drivers/tty/serial/sc16is7xx.c: In function 'sc16is7xx_ioctl':
>> drivers/tty/serial/sc16is7xx.c:861:3: error: implicit declaration of function 'copy_from_user' [-Werror=implicit-function-declaration]
>> drivers/tty/serial/sc16is7xx.c:867:3: error: implicit declaration of function 'copy_to_user' [-Werror=implicit-function-declaration]

Signed-off-by: Jon Ringle <[email protected]>
---
drivers/tty/serial/sc16is7xx.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index ed139f5..7206a64 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -25,6 +25,7 @@
#include <linux/serial.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>
+#include <linux/uaccess.h>

#define SC16IS7XX_NAME "sc16is7xx"

--
1.8.5.4

2014-04-25 20:20:22

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

On Fri, Apr 25, 2014 at 03:53:09PM -0400, [email protected] wrote:
> From: Jon Ringle <[email protected]>
>
> Signed-off-by: Jon Ringle <[email protected]>
> ---
> drivers/tty/serial/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index c3e2b32..64c5659 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
>
> config SERIAL_SC16IS7XX
> tristate "SC16IS7xx serial support"
> + depends on I2C
> select SERIAL_CORE
> select REGMAP_I2C if I2C
> help
> --
> 1.8.5.4

Better, but I still have the build warnings :(

2014-04-25 20:26:39

by Alexander Shiyan

Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <[email protected]>:
> On Fri, Apr 25, 2014 at 03:53:09PM -0400, [email protected] wrote:
> > From: Jon Ringle <[email protected]>
> >
> > Signed-off-by: Jon Ringle <[email protected]>
> > ---
> > drivers/tty/serial/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index c3e2b32..64c5659 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
> >
> > config SERIAL_SC16IS7XX
> > tristate "SC16IS7xx serial support"
> > + depends on I2C
> > select SERIAL_CORE
> > select REGMAP_I2C if I2C
> > help
> > --
> > 1.8.5.4
>
> Better, but I still have the build warnings :(

I hope not same as before?

---

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2014-04-25 20:32:36

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
> Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <[email protected]>:
> > On Fri, Apr 25, 2014 at 03:53:09PM -0400, [email protected] wrote:
> > > From: Jon Ringle <[email protected]>
> > >
> > > Signed-off-by: Jon Ringle <[email protected]>
> > > ---
> > > drivers/tty/serial/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > index c3e2b32..64c5659 100644
> > > --- a/drivers/tty/serial/Kconfig
> > > +++ b/drivers/tty/serial/Kconfig
> > > @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
> > >
> > > config SERIAL_SC16IS7XX
> > > tristate "SC16IS7xx serial support"
> > > + depends on I2C
> > > select SERIAL_CORE
> > > select REGMAP_I2C if I2C
> > > help
> > > --
> > > 1.8.5.4
> >
> > Better, but I still have the build warnings :(
>
> I hope not same as before?

Exactly the same.

2014-04-25 20:40:28

by Alexander Shiyan

Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

Fri, 25 Apr 2014 13:35:28 -0700 от Greg KH <[email protected]>:
> On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
> > Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <[email protected]>:
> > > On Fri, Apr 25, 2014 at 03:53:09PM -0400, [email protected] wrote:
> > > > From: Jon Ringle <[email protected]>
> > > >
> > > > Signed-off-by: Jon Ringle <[email protected]>
> > > > ---
> > > > drivers/tty/serial/Kconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > > > index c3e2b32..64c5659 100644
> > > > --- a/drivers/tty/serial/Kconfig
> > > > +++ b/drivers/tty/serial/Kconfig
> > > > @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
> > > >
> > > > config SERIAL_SC16IS7XX
> > > > tristate "SC16IS7xx serial support"
> > > > + depends on I2C
> > > > select SERIAL_CORE
> > > > select REGMAP_I2C if I2C
> > > > help
> > > > --
> > > > 1.8.5.4
> > >
> > > Better, but I still have the build warnings :(
> >
> > I hope not same as before?
>
> Exactly the same.

Hmm...

In the source:
#ifdef CONFIG_REGMAP_I2C
Should be of course #ifdef CONFIG_I2C
But this should not provide such warnings...

---

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?

2014-04-25 20:42:27

by Randy Dunlap

Subject: Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

On 04/25/14 13:39, Alexander Shiyan wrote:
> Fri, 25 Apr 2014 13:35:28 -0700 от Greg KH <[email protected]>:
>> On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
>>> Fri, 25 Apr 2014 13:23:15 -0700 от Greg KH <[email protected]>:
>>>> On Fri, Apr 25, 2014 at 03:53:09PM -0400, [email protected] wrote:
>>>>> From: Jon Ringle <[email protected]>
>>>>>
>>>>> Signed-off-by: Jon Ringle <[email protected]>
>>>>> ---
>>>>> drivers/tty/serial/Kconfig | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>>>> index c3e2b32..64c5659 100644
>>>>> --- a/drivers/tty/serial/Kconfig
>>>>> +++ b/drivers/tty/serial/Kconfig
>>>>> @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
>>>>>
>>>>> config SERIAL_SC16IS7XX
>>>>> tristate "SC16IS7xx serial support"
>>>>> + depends on I2C
>>>>> select SERIAL_CORE
>>>>> select REGMAP_I2C if I2C
>>>>> help
>>>>> --
>>>>> 1.8.5.4
>>>>
>>>> Better, but I still have the build warnings :(
>>>
>>> I hope not same as before?
>>
>> Exactly the same.
>
> Hmm...
>
> In the source:
> #ifdef CONFIG_REGMAP_I2C
> Should be of course #ifdef CONFIG_I2C
> But this should not provide such warnings...

Can I see the warnings and .config file that causes them?


--
~Randy