From: "Ivan T. Ivanov" <[email protected]>
This fixes following:
WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe()
The variable msm_otg_driver references
the function __init msm_otg_probe()
Signed-off-by: Ivan T. Ivanov <[email protected]>
---
drivers/usb/phy/phy-msm-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
index 5b37b81..6ae4d2f 100644
--- a/drivers/usb/phy/phy-msm-usb.c
+++ b/drivers/usb/phy/phy-msm-usb.c
@@ -1406,7 +1406,7 @@ static void msm_otg_debugfs_cleanup(void)
debugfs_remove(msm_otg_dbg_root);
}
-static int __init msm_otg_probe(struct platform_device *pdev)
+static int msm_otg_probe(struct platform_device *pdev)
{
int ret = 0;
struct resource *res;
--
1.8.3.2
On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote:
> On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote:
> >
> > >From: "Ivan T. Ivanov" <[email protected]>
> >
> > >This fixes following:
> >
> > >WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe()
> > >The variable msm_otg_driver references
> > >the function __init msm_otg_probe()
> >
> > Hm, this warning shouldn't occur before patch #4, no?
>
> good catch, this could probably be merged there.
True. Should I resend it?
Regards,
Ivan
On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote:
> On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote:
> > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote:
> > > Hello.
> > >
> > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote:
> > >
> > > >From: "Ivan T. Ivanov" <[email protected]>
> > >
> > > >This fixes following:
> > >
> > > >WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe()
> > > >The variable msm_otg_driver references
> > > >the function __init msm_otg_probe()
> > >
> > > Hm, this warning shouldn't occur before patch #4, no?
> >
> > good catch, this could probably be merged there.
>
> True. Should I resend it?
hold on, that's simple enough to sort out while applying. Unless there
are any other big comments with your series, no need to resend.
cheers
--
balbi
On Mon, 2014-04-28 at 12:54 -0500, Felipe Balbi wrote:
> On Mon, Apr 28, 2014 at 08:52:48PM +0300, Ivan T. Ivanov wrote:
> > On Mon, 2014-04-28 at 12:03 -0500, Felipe Balbi wrote:
> > > On Mon, Apr 28, 2014 at 09:00:43PM +0400, Sergei Shtylyov wrote:
> > > > Hello.
> > > >
> > > > On 04/28/2014 05:34 PM, Ivan T. Ivanov wrote:
> > > >
> > > > >From: "Ivan T. Ivanov" <[email protected]>
> > > >
> > > > >This fixes following:
> > > >
> > > > >WARNING: drivers/usb/phy/built-in.o(.data+0x68): Section mismatch in reference from the variable msm_otg_driver to the function .init.text:msm_otg_probe()
> > > > >The variable msm_otg_driver references
> > > > >the function __init msm_otg_probe()
> > > >
> > > > Hm, this warning shouldn't occur before patch #4, no?
> > >
> > > good catch, this could probably be merged there.
> >
> > True. Should I resend it?
>
> hold on, that's simple enough to sort out while applying. Unless there
> are any other big comments with your series, no need to resend.
Sure, I will wait for more comments.
Thanks,
Ivan
>
> cheers
>