2014-05-01 00:17:30

by Jim Keniston

[permalink] [raw]
Subject: Re: [PATCH v3] uprobes: simplify rip-relative handling

On Mon, 2014-04-28 at 19:06 +0200, Denys Vlasenko wrote:
> It is possible to replace rip-relative addressing mode
> with addressing mode of the same length: (reg+disp32).
> This eliminates the need to fix up immediate
> and correct for changing instruction length.
>
> v2: Rebased on top of Oleg's latest changes and run-tested.
> v3: Removed unnecessary cast.
> Improved comments based on Oleg's feedback.
>
> Signed-off-by: Denys Vlasenko <[email protected]>
> CC: Jim Keniston <[email protected]>
> CC: Masami Hiramatsu <[email protected]>
> CC: Srikar Dronamraju <[email protected]>
> CC: Ingo Molnar <[email protected]>
> CC: Oleg Nesterov <[email protected]>

Thanks, Denys.
Reviewed-by: Jim Keniston <[email protected]>