2014-06-01 11:37:34

by Rickard Strandqvist

Subject: [PATCH] tools: perf: builtin-trace.c: Cleaning up memory leak

There is a risk for memory leak in when something unexpected happens
and the function returns.

This was largely found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
tools/perf/builtin-trace.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index f954c26..e6b3df9 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -1855,6 +1855,7 @@ static int trace__record(int argc, const char **argv)
rec_argv[i] = "syscalls:sys_enter,syscalls:sys_exit";
else {
pr_err("Neither raw_syscalls nor syscalls events exist.\n");
+ free(rec_argv);
return -1;
}
i++;
--
1.7.10.4

2014-06-03 03:14:24

by Namhyung Kim

Subject: Re: [PATCH] tools: perf: builtin-trace.c: Cleaning up memory leak

On Sun, 1 Jun 2014 13:38:26 +0200, Rickard Strandqvist wrote:
> There is a risk for memory leak in when something unexpected happens
> and the function returns.
>
> This was largely found by using a static code analysis program called cppcheck.

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung