2014-06-13 06:15:57

by Pramod Gurav

Subject: [PATCH v2 1/2] alarmtimer: Export symbols of alarmtimer_get_rtcdev

From: Pramod Gurav <[email protected]>

Export symbol of alarmtimer_get_rtcdev so that it is used by
any driver when built as module like,
drivers/staging/android/alarm-dev.c.

CC: John Stultz <[email protected]>
CC: Marcus Gelderie <[email protected]>
CC: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
---

This Export was missing in Marcus's below patch:

https://lkml.org/lkml/2013/6/1/144

Changes since v1:
-Removed trivial list from CC

kernel/time/alarmtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index 88c9c65..a53ba0b 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -71,7 +71,7 @@ struct rtc_device *alarmtimer_get_rtcdev(void)

return ret;
}
-
+EXPORT_SYMBOL_GPL(alarmtimer_get_rtcdev);

static int alarmtimer_rtc_add_device(struct device *dev,
struct class_interface *class_intf)
--
1.7.9.5

2014-06-13 06:16:06

by Pramod Gurav

Subject: [PATCH v2 2/2] staging: alarm-dev: Support to Compile as Module

From: Pramod Gurav <[email protected]>

Currently this alarm-dev can be compiles only as built in
driver. This adds support to compile it as module as well which is in
planned activity (See drivers/staging/android/TODO)


CC: Greg Kroah-Hartman <[email protected]>
CC: Brian Swetland <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
---
drivers/staging/android/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 99e484f..c359317 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
Registers processes to be killed when memory is low

config ANDROID_INTF_ALARM_DEV
- bool "Android alarm driver"
+ tristate "Android alarm driver"
depends on RTC_CLASS
default n
---help---
--
1.7.9.5

2014-06-20 00:27:57

by Greg KH

Subject: Re: [PATCH v2 2/2] staging: alarm-dev: Support to Compile as Module

On Fri, Jun 13, 2014 at 11:49:43AM +0530, [email protected] wrote:
> From: Pramod Gurav <[email protected]>
>
> Currently this alarm-dev can be compiles only as built in
> driver. This adds support to compile it as module as well which is in
> planned activity (See drivers/staging/android/TODO)
>
>
> CC: Greg Kroah-Hartman <[email protected]>
> CC: Brian Swetland <[email protected]>
> Signed-off-by: Pramod Gurav <[email protected]>
> ---
> drivers/staging/android/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 99e484f..c359317 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -76,7 +76,7 @@ config ANDROID_LOW_MEMORY_KILLER
> Registers processes to be killed when memory is low
>
> config ANDROID_INTF_ALARM_DEV
> - bool "Android alarm driver"
> + tristate "Android alarm driver"
> depends on RTC_CLASS
> default n
> ---help---

With this change you will get a warning about a missing
MODULE_LICENSE(), can you please send a follow-on patch to fix that?

thanks,

greg k-h