2014-06-13 20:02:19

by Christoph Jaeger

[permalink] [raw]
Subject: [PATCH] i2c-taos-evm: Use module_serio_driver()

Get rid of some boilerplate code by using module_serio_driver().

Signed-off-by: Christoph Jaeger <[email protected]>
---
drivers/i2c/busses/i2c-taos-evm.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
index 0576026..10855a0 100644
--- a/drivers/i2c/busses/i2c-taos-evm.c
+++ b/drivers/i2c/busses/i2c-taos-evm.c
@@ -311,19 +311,8 @@ static struct serio_driver taos_drv = {
.interrupt = taos_interrupt,
};

-static int __init taos_init(void)
-{
- return serio_register_driver(&taos_drv);
-}
-
-static void __exit taos_exit(void)
-{
- serio_unregister_driver(&taos_drv);
-}
+module_serio_driver(taos_drv);

MODULE_AUTHOR("Jean Delvare <[email protected]>");
MODULE_DESCRIPTION("TAOS evaluation module driver");
MODULE_LICENSE("GPL");
-
-module_init(taos_init);
-module_exit(taos_exit);
--
1.9.3


2014-06-13 21:23:08

by Jean Delvare

[permalink] [raw]
Subject: Re: [PATCH] i2c-taos-evm: Use module_serio_driver()

On Fri, 13 Jun 2014 21:52:24 +0200, Christoph Jaeger wrote:
> Get rid of some boilerplate code by using module_serio_driver().
>
> Signed-off-by: Christoph Jaeger <[email protected]>
> ---
> drivers/i2c/busses/i2c-taos-evm.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-taos-evm.c b/drivers/i2c/busses/i2c-taos-evm.c
> index 0576026..10855a0 100644
> --- a/drivers/i2c/busses/i2c-taos-evm.c
> +++ b/drivers/i2c/busses/i2c-taos-evm.c
> @@ -311,19 +311,8 @@ static struct serio_driver taos_drv = {
> .interrupt = taos_interrupt,
> };
>
> -static int __init taos_init(void)
> -{
> - return serio_register_driver(&taos_drv);
> -}
> -
> -static void __exit taos_exit(void)
> -{
> - serio_unregister_driver(&taos_drv);
> -}
> +module_serio_driver(taos_drv);
>
> MODULE_AUTHOR("Jean Delvare <[email protected]>");
> MODULE_DESCRIPTION("TAOS evaluation module driver");
> MODULE_LICENSE("GPL");
> -
> -module_init(taos_init);
> -module_exit(taos_exit);

Reviewed-by: Jean Delvare <[email protected]>

Thanks,
--
Jean Delvare
SUSE L3 Support

2014-06-27 11:25:13

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c-taos-evm: Use module_serio_driver()

On Fri, Jun 13, 2014 at 09:52:24PM +0200, Christoph Jaeger wrote:
> Get rid of some boilerplate code by using module_serio_driver().
>
> Signed-off-by: Christoph Jaeger <[email protected]>

Applied to for-next, thanks!

Attachments:
(No filename) (229.00 B)
 signature.asc (819.00 B)
Digital signature Download all attachments