2014-06-19 22:32:20

by Greg Thelen

Subject: [PATCH] memcg: remove lookup_cgroup_page() prototype

6b208e3f6e35 ("mm: memcg: remove unused node/section info from
pc->flags") deleted the lookup_cgroup_page() function but left a
prototype for it.

Kill the vestigial prototype.

Signed-off-by: Greg Thelen <[email protected]>
---
include/linux/page_cgroup.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h
index 777a524716db..0ff470de3c12 100644
--- a/include/linux/page_cgroup.h
+++ b/include/linux/page_cgroup.h
@@ -42,7 +42,6 @@ static inline void __init page_cgroup_init(void)
#endif

struct page_cgroup *lookup_page_cgroup(struct page *page);
-struct page *lookup_cgroup_page(struct page_cgroup *pc);

#define TESTPCGFLAG(uname, lname) \
static inline int PageCgroup##uname(struct page_cgroup *pc) \
--
2.0.0.526.g5318336

2014-06-23 09:14:24

by Michal Hocko

Subject: Re: [PATCH] memcg: remove lookup_cgroup_page() prototype

On Thu 19-06-14 15:32:16, Greg Thelen wrote:
> 6b208e3f6e35 ("mm: memcg: remove unused node/section info from
> pc->flags") deleted the lookup_cgroup_page() function but left a
> prototype for it.
>
> Kill the vestigial prototype.
>
> Signed-off-by: Greg Thelen <[email protected]>

Acked-by: Michal Hocko <[email protected]>

> ---
> include/linux/page_cgroup.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/page_cgroup.h b/include/linux/page_cgroup.h
> index 777a524716db..0ff470de3c12 100644
> --- a/include/linux/page_cgroup.h
> +++ b/include/linux/page_cgroup.h
> @@ -42,7 +42,6 @@ static inline void __init page_cgroup_init(void)
> #endif
>
> struct page_cgroup *lookup_page_cgroup(struct page *page);
> -struct page *lookup_cgroup_page(struct page_cgroup *pc);
>
> #define TESTPCGFLAG(uname, lname) \
> static inline int PageCgroup##uname(struct page_cgroup *pc) \
> --
> 2.0.0.526.g5318336
>

--
Michal Hocko
SUSE Labs