2014-06-20 21:51:29

by Emil Goode

[permalink] [raw]

Subject: [PATCH] video: Remove kfree call since devm_kzalloc() is used

---

We use devm_kzalloc() to allocate memory for the struct vt8500lcd_info
pointer fbi, so there is no need to free it in vt8500lcd_remove().

Signed-off-by: Emil Goode <[email protected]>
---
drivers/video/fbdev/vt8500lcdfb.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
index a8f2b28..a1134c3 100644
--- a/drivers/video/fbdev/vt8500lcdfb.c
+++ b/drivers/video/fbdev/vt8500lcdfb.c
@@ -474,8 +474,6 @@ static int vt8500lcd_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, resource_size(res));

- kfree(fbi);
-
return 0;
}

--
1.7.10.4

2014-06-23 11:11:49

by Tomi Valkeinen

[permalink] [raw]

Subject: Re: [PATCH] video: Remove kfree call since devm_kzalloc() is used

---

On 21/06/14 00:50, Emil Goode wrote:
> We use devm_kzalloc() to allocate memory for the struct vt8500lcd_info
> pointer fbi, so there is no need to free it in vt8500lcd_remove().
>
> Signed-off-by: Emil Goode <[email protected]>
> ---
> drivers/video/fbdev/vt8500lcdfb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/vt8500lcdfb.c b/drivers/video/fbdev/vt8500lcdfb.c
> index a8f2b28..a1134c3 100644
> --- a/drivers/video/fbdev/vt8500lcdfb.c
> +++ b/drivers/video/fbdev/vt8500lcdfb.c
> @@ -474,8 +474,6 @@ static int vt8500lcd_remove(struct platform_device *pdev)
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> release_mem_region(res->start, resource_size(res));
>
> - kfree(fbi);
> -
> return 0;
> }
>
>

Thanks, queued for 3.17.

Tomi

---

Attachments:

signature.asc (819.00 B)
OpenPGP digital signature