2014-06-22 10:01:26

by Ondrej Zary

Subject: [PATCH] tulip: Poll link status more frequently for Comet chips

It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips.
That's too slow and might cause people to think that it doesn't work at all.

Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
That should be fast enough while not stressing the system too much.

Tested with ADMtek AN983B.

Signed-off-by: Ondrej Zary <[email protected]>
---
drivers/net/ethernet/dec/tulip/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/dec/tulip/timer.c b/drivers/net/ethernet/dec/tulip/timer.c
index 768379b..523d9dd 100644
--- a/drivers/net/ethernet/dec/tulip/timer.c
+++ b/drivers/net/ethernet/dec/tulip/timer.c
@@ -158,7 +158,7 @@ void comet_timer(unsigned long data)
{
struct net_device *dev = (struct net_device *)data;
struct tulip_private *tp = netdev_priv(dev);
- int next_tick = 60*HZ;
+ int next_tick = 2*HZ;

if (tulip_debug > 1)
netdev_dbg(dev, "Comet link status %04x partner capability %04x\n",
--
Ondrej Zary

2014-06-23 00:13:08

by David Miller

Subject: Re: [PATCH] tulip: Poll link status more frequently for Comet chips

From: Ondrej Zary <[email protected]>
Date: Sun, 22 Jun 2014 12:01:12 +0200

> It now takes up to 60 seconds to detect cable (un)plug on ADMtek Comet chips.
> That's too slow and might cause people to think that it doesn't work at all.
>
> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
> That should be fast enough while not stressing the system too much.
>
> Tested with ADMtek AN983B.
>
> Signed-off-by: Ondrej Zary <[email protected]>

Looks good, and this is consistent with tulip_media_timer().

Applied, thanks.