2014-06-23 14:43:38

by Maxime Bizon

Subject: [PATCH] workqueue: fix dev_set_uevent_suppress imbalance.

Uevents are suppressed during attributes registration, but never
restored, so kobject_uevent() does nothing.

Signed-off-by: Maxime Bizon <[email protected]>
---
kernel/workqueue.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 6203d29..6f5f9c7 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3284,6 +3284,7 @@ int workqueue_sysfs_register(struct workqueue_struct *wq)
}
}

+ dev_set_uevent_suppress(&wq_dev->dev, false);
kobject_uevent(&wq_dev->dev.kobj, KOBJ_ADD);
return 0;
}
--
1.7.9.5

2014-06-23 18:42:52

by Tejun Heo

Subject: Re: [PATCH] workqueue: fix dev_set_uevent_suppress imbalance.

On Mon, Jun 23, 2014 at 04:35:35PM +0200, Maxime Bizon wrote:
> Uevents are suppressed during attributes registration, but never
> restored, so kobject_uevent() does nothing.
>
> Signed-off-by: Maxime Bizon <[email protected]>

Applied to wq/for-3.16-fixes.

Thanks.

--
tejun