2014-06-23 16:35:09

by Fabian Frédérick

Subject: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Peter Ujfalusi <[email protected]>
Cc: Jarkko Nikula <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
sound/soc/omap/mcbsp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
index 86c7538..68a1252 100644
--- a/sound/soc/omap/mcbsp.c
+++ b/sound/soc/omap/mcbsp.c
@@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
mcbsp->reg_cache = NULL;
spin_unlock(&mcbsp->lock);

- if (reg_cache)
- kfree(reg_cache);
+ kfree(reg_cache);
}

/*
--
1.8.4.5

2014-06-24 07:48:42

by Peter Ujfalusi

Subject: Re: [PATCH 1/1] sound/soc/omap/mcbsp.c: remove unnecessary null test before kfree

Hi Fabian,

On 06/23/2014 07:33 PM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required

can you send the same patch to alsa-devel with subject:
ASoC: mcbsp: remove unnecessary null test before kfree

You can add my:
Acked-by: Peter Ujfalusi <[email protected]>

>
> Cc: Peter Ujfalusi <[email protected]>
> Cc: Jarkko Nikula <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> sound/soc/omap/mcbsp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
> index 86c7538..68a1252 100644
> --- a/sound/soc/omap/mcbsp.c
> +++ b/sound/soc/omap/mcbsp.c
> @@ -621,8 +621,7 @@ void omap_mcbsp_free(struct omap_mcbsp *mcbsp)
> mcbsp->reg_cache = NULL;
> spin_unlock(&mcbsp->lock);
>
> - if (reg_cache)
> - kfree(reg_cache);
> + kfree(reg_cache);
> }
>
> /*
>


--
P?ter