2014-06-24 08:28:05

by Sachin Kamat

[permalink] [raw]
Subject: [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization

'name' field was re-initialized and getting overwritten in some
cases possibly due to a typo. Code inspection says the second time
it should be 'sname' instead of 'name'. Replace it.

Signed-off-by: Sachin Kamat <[email protected]>
---
Compile tested only.
---
drivers/regulator/as3722-regulator.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
index ad9e0c9b7daf..b68f05f38537 100644
--- a/drivers/regulator/as3722-regulator.c
+++ b/drivers/regulator/as3722-regulator.c
@@ -219,7 +219,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO3,
.name = "as3722-ldo3",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO3_VOLTAGE_REG,
.vsel_mask = AS3722_LDO3_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
@@ -231,7 +231,7 @@ static const struct as3722_register_mapping as3722_reg_lookup[] = {
{
.regulator_id = AS3722_REGULATOR_ID_LDO4,
.name = "as3722-ldo4",
- .name = "vin-ldo3-4",
+ .sname = "vin-ldo3-4",
.vsel_reg = AS3722_LDO4_VOLTAGE_REG,
.vsel_mask = AS3722_LDO_VSEL_MASK,
.enable_reg = AS3722_LDOCONTROL0_REG,
--
1.7.9.5


2014-06-24 08:39:01

by Laxman Dewangan

[permalink] [raw]
Subject: Re: [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization

On Tuesday 24 June 2014 01:54 PM, Sachin Kamat wrote:
> 'name' field was re-initialized and getting overwritten in some
> cases possibly due to a typo. Code inspection says the second time
> it should be 'sname' instead of 'name'. Replace it.
>
> Signed-off-by: Sachin Kamat <[email protected]>
>


Agree, thanks for finding this.

Reviewed-by: Laxman Dewangan <[email protected]>

2014-06-24 15:10:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/1] regulator: as3722: Fix incorrect parameter initialization

On Tue, Jun 24, 2014 at 01:54:43PM +0530, Sachin Kamat wrote:
> 'name' field was re-initialized and getting overwritten in some
> cases possibly due to a typo. Code inspection says the second time
> it should be 'sname' instead of 'name'. Replace it.

Applied, thanks.


Attachments:
(No filename) (269.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments