2014-06-24 09:12:25

by Sachin Kamat

Subject: [PATCH 1/1] mfd: pm8921-core: Remove unused variable

‘irq_bit’ is unused in the function. Remove it.

Signed-off-by: Sachin Kamat <[email protected]>
---
Compile tested.
---
drivers/mfd/pm8921-core.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 959513803542..39904f77c049 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
{
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
- int irq_bit;
u8 block, config;

block = pmirq / 8;
- irq_bit = pmirq % 8;

config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
pm8xxx_config_irq(chip, block, config);
@@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
{
struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
unsigned int pmirq = irqd_to_hwirq(d);
- int irq_bit;
u8 block, config;

block = pmirq / 8;
- irq_bit = pmirq % 8;

config = chip->config[pmirq];
pm8xxx_config_irq(chip, block, config);
--
1.7.9.5

2014-06-24 12:10:23

by Lee Jones

Subject: Re: [PATCH 1/1] mfd: pm8921-core: Remove unused variable

On Tue, 24 Jun 2014, Sachin Kamat wrote:

> ‘irq_bit’ is unused in the function. Remove it.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> Compile tested.
> ---
> drivers/mfd/pm8921-core.c | 4 ----
> 1 file changed, 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
> index 959513803542..39904f77c049 100644
> --- a/drivers/mfd/pm8921-core.c
> +++ b/drivers/mfd/pm8921-core.c
> @@ -186,11 +186,9 @@ static void pm8xxx_irq_mask_ack(struct irq_data *d)
> {
> struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
> unsigned int pmirq = irqd_to_hwirq(d);
> - int irq_bit;
> u8 block, config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq] | PM_IRQF_MASK_ALL | PM_IRQF_CLR;
> pm8xxx_config_irq(chip, block, config);
> @@ -200,11 +198,9 @@ static void pm8xxx_irq_unmask(struct irq_data *d)
> {
> struct pm_irq_chip *chip = irq_data_get_irq_chip_data(d);
> unsigned int pmirq = irqd_to_hwirq(d);
> - int irq_bit;
> u8 block, config;
>
> block = pmirq / 8;
> - irq_bit = pmirq % 8;
>
> config = chip->config[pmirq];
> pm8xxx_config_irq(chip, block, config);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog