2014-06-24 10:48:40

by Rickard Strandqvist

Subject: [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case

Added a missed break in a case statement

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
sound/oss/mpu401.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
index 25e4609..400896b 100644
--- a/sound/oss/mpu401.c
+++ b/sound/oss/mpu401.c
@@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic)
case 0xf6:
/* printk( "tune_request\n"); */
devc->m_state = ST_INIT;
+ break;

/*
* Real time messages
--
1.7.10.4

2014-06-24 12:17:31

by Takashi Iwai

Subject: Re: [PATCH] sound: oss: mpu401.c: Cleaning up missing break in a case

At Tue, 24 Jun 2014 12:49:35 +0200,
Rickard Strandqvist wrote:
>
> Added a missed break in a case statement
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Thanks, applied.


Takashi

> ---
> sound/oss/mpu401.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/oss/mpu401.c b/sound/oss/mpu401.c
> index 25e4609..400896b 100644
> --- a/sound/oss/mpu401.c
> +++ b/sound/oss/mpu401.c
> @@ -316,6 +316,7 @@ static int mpu_input_scanner(struct mpu_config *devc, unsigned char midic)
> case 0xf6:
> /* printk( "tune_request\n"); */
> devc->m_state = ST_INIT;
> + break;
>
> /*
> * Real time messages
> --
> 1.7.10.4
>