2014-06-24 11:08:14

by Rickard Strandqvist

[permalink] [raw]
Subject: [PATCH] tools: lib: traceevent: event-parse.c: Fix a risk for doing free on uninitialized pointer

Fix a risk of doing free on an uninitialized pointer.

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <[email protected]>
---
tools/lib/traceevent/event-parse.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index b83184f..857675e 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2390,7 +2390,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;

memset(arg, 0, sizeof(*arg));
arg->type = PRINT_FLAGS;
@@ -2443,7 +2443,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;

memset(arg, 0, sizeof(*arg));
arg->type = PRINT_SYMBOL;
@@ -2482,7 +2482,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;

memset(arg, 0, sizeof(*arg));
arg->type = PRINT_HEX;
--
1.7.10.4


2014-06-25 01:04:51

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH] tools: lib: traceevent: event-parse.c: Fix a risk for doing free on uninitialized pointer

Hi Rickard,

On Tue, 24 Jun 2014 13:09:10 +0200, Rickard Strandqvist wrote:
> Fix a risk of doing free on an uninitialized pointer.
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/lib/traceevent/event-parse.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index b83184f..857675e 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -2390,7 +2390,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok)
> {
> struct print_arg *field;
> enum event_type type;
> - char *token;
> + char *token = NULL;
>
> memset(arg, 0, sizeof(*arg));
> arg->type = PRINT_FLAGS;
> @@ -2443,7 +2443,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok)
> {
> struct print_arg *field;
> enum event_type type;
> - char *token;
> + char *token = NULL;
>
> memset(arg, 0, sizeof(*arg));
> arg->type = PRINT_SYMBOL;
> @@ -2482,7 +2482,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok)
> {
> struct print_arg *field;
> enum event_type type;
> - char *token;
> + char *token = NULL;
>
> memset(arg, 0, sizeof(*arg));
> arg->type = PRINT_HEX;

2014-06-25 07:33:32

by Jiri Olsa

[permalink] [raw]
Subject: Re: [PATCH] tools: lib: traceevent: event-parse.c: Fix a risk for doing free on uninitialized pointer

On Wed, Jun 25, 2014 at 10:04:47AM +0900, Namhyung Kim wrote:
> Hi Rickard,
>
> On Tue, 24 Jun 2014 13:09:10 +0200, Rickard Strandqvist wrote:
> > Fix a risk of doing free on an uninitialized pointer.
> >
> > This was found using a static code analysis program called cppcheck.
> >
> > Signed-off-by: Rickard Strandqvist <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>

thanks, queued

jirka

Subject: [tip:perf/core] tools lib traceevent: Fix a risk for doing free on uninitialized pointer

Commit-ID: 21da83fb6c3ff67e969b8770bbb33138c9ede88e
Gitweb: http://git.kernel.org/tip/21da83fb6c3ff67e969b8770bbb33138c9ede88e
Author: Rickard Strandqvist <[email protected]>
AuthorDate: Tue, 24 Jun 2014 13:09:10 +0200
Committer: Jiri Olsa <[email protected]>
CommitDate: Fri, 27 Jun 2014 11:14:47 +0200

tools lib traceevent: Fix a risk for doing free on uninitialized pointer

Fix a risk of doing free on an uninitialized pointer.

This was found using a static code analysis program called cppcheck.

Acked-by: Namhyung Kim <[email protected]>
Signed-off-by: Rickard Strandqvist <[email protected]>
Link: http://lkml.kernel.org/r/1403608150-13037-1-git-send-email-rickard_strandqvist@spectrumdigital.se
Signed-off-by: Jiri Olsa <[email protected]>
---
tools/lib/traceevent/event-parse.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 93825a1..cf3a44b 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -2395,7 +2395,7 @@ process_flags(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;

memset(arg, 0, sizeof(*arg));
arg->type = PRINT_FLAGS;
@@ -2448,7 +2448,7 @@ process_symbols(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;

memset(arg, 0, sizeof(*arg));
arg->type = PRINT_SYMBOL;
@@ -2487,7 +2487,7 @@ process_hex(struct event_format *event, struct print_arg *arg, char **tok)
{
struct print_arg *field;
enum event_type type;
- char *token;
+ char *token = NULL;

memset(arg, 0, sizeof(*arg));
arg->type = PRINT_HEX;